SVG2 changes element inheritance so all SVGElements are stylable. As a first-step towards a cleaner class hierarchy, we can move SVGStylable into SVGStyledElement. New interface for SVGElement: https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement
Created attachment 182708 [details] First pass - still need to fix a couple build files.
Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15884484
Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15868807
Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/15860847
Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/15873784
Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Attachment 182708 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/15841865
It builds on Chrome! 6 platforms to go! :)
Comment on attachment 182708 [details] First pass - still need to fix a couple build files. Should work better after modifying the ObjC bindings and the bindings for Qt and Gtk. But I would like to have a FIXME in SVGStyledElement.h that is should be combined with SVGElement after resolving cycle dependencies between SVGAnimationString and SVGElement (as specified in SVG2).
Created attachment 183646 [details] Update all build systems
Comment on attachment 183646 [details] Update all build systems View in context: https://bugs.webkit.org/attachment.cgi?id=183646&action=review Patch looks great! Waiting for the bots before setting r+. > Source/WebCore/WebCore.exp.in:2634 > .objc_class_name_DOMSVGStyleElement Shouldn't you remove this one?
(In reply to comment #10) > (From update of attachment 183646 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=183646&action=review > > Patch looks great! Waiting for the bots before setting r+. Yes, please do :) > > > Source/WebCore/WebCore.exp.in:2634 > > .objc_class_name_DOMSVGStyleElement > > Shouldn't you remove this one? No, that's for <style> which is still needed.
Comment on attachment 183646 [details] Update all build systems Attachment 183646 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15970388
Comment on attachment 183646 [details] Update all build systems Attachment 183646 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15974413
(In reply to comment #11) > (In reply to comment #10) > > > Source/WebCore/WebCore.exp.in:2634 > > > .objc_class_name_DOMSVGStyleElement > > > > Shouldn't you remove this one? > > No, that's for <style> which is still needed. Ah right, mixed it up with Stylable.
Created attachment 183647 [details] Add a ChangeLog entry somebody forgot
Comment on attachment 183647 [details] Add a ChangeLog entry somebody forgot Attachment 183647 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/15973431
Comment on attachment 183647 [details] Add a ChangeLog entry somebody forgot Attachment 183647 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/15972395
Created attachment 183649 [details] Update DerivedSources for QT EWS happiness.
Comment on attachment 183649 [details] Update DerivedSources for QT EWS happiness. Bots seem happy! Marking for review
Comment on attachment 183649 [details] Update DerivedSources for QT EWS happiness. r=me
Comment on attachment 183649 [details] Update DerivedSources for QT EWS happiness. Clearing flags on attachment: 183649 Committed r140265: <http://trac.webkit.org/changeset/140265>
All reviewed patches have been landed. Closing bug.