Bug 120155 - Introduce a SVGUnknownElement class for unknown SVG elements
Summary: Introduce a SVGUnknownElement class for unknown SVG elements
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 107386
  Show dependency treegraph
Reported: 2013-08-22 04:21 PDT by Chris Dumez
Modified: 2013-08-22 05:37 PDT (History)
11 users (show)

See Also:

Patch (14.16 KB, patch)
2013-08-22 04:55 PDT, Chris Dumez
kling: review+
Details | Formatted Diff | Diff
Patch for landing (13.42 KB, patch)
2013-08-22 05:07 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-08-22 04:21:26 PDT
Introduce a SVGUnknownElement class and have it override rendererIsNeeded() to return false. We now use SVGUnknownElement type (instead of SVGElement) for unknown SVG elements:
- Unknown Elements in SVG namespace
- Registered custom tag elements in SVG namespace (http://www.w3.org/TR/2013/WD-custom-elements-20130514/#registering-custom-elements)

As a consequence, SVGElement::rendererIsNeeded() is not longer required to return false and it will be able to behave as SVGStyledElement::rendererIsNeeded() once we merge SVGStyledElement into SVGElement.

This is a pre-requirement to merging SVGStyledElement into SVGElement (Bug 107386).

Corresponding Blink revision:
Comment 1 Chris Dumez 2013-08-22 04:55:20 PDT
Created attachment 209347 [details]
Comment 2 Andreas Kling 2013-08-22 04:57:39 PDT
Comment on attachment 209347 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=209347&action=review


> Source/WebCore/svg/SVGUnknownElement.h:41
> +class SVGUnknownElement : public SVGElement {

This class should be FINAL since it has no subclasses.
Comment 3 Chris Dumez 2013-08-22 05:07:38 PDT
Created attachment 209349 [details]
Patch for landing

Made the class FINAL.
Comment 4 WebKit Commit Bot 2013-08-22 05:37:17 PDT
Comment on attachment 209349 [details]
Patch for landing

Clearing flags on attachment: 209349

Committed r154443: <http://trac.webkit.org/changeset/154443>
Comment 5 WebKit Commit Bot 2013-08-22 05:37:20 PDT
All reviewed patches have been landed.  Closing bug.