Bug 118474 - Reduce number of header includes in SVG
Summary: Reduce number of header includes in SVG
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks: 107386
  Show dependency tree / graph
 
Reported: 2013-07-08 09:39 PDT by Chris Dumez
Modified: 2013-07-10 16:49 PDT (History)
15 users (show)

See Also:

Attachments
Patch (67.76 KB, patch)
2013-07-09 03:38 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (68.04 KB, patch)
2013-07-09 03:41 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (68.53 KB, patch)
2013-07-09 03:56 PDT, Chris Dumez 		rwlbuis: review+
Details | Formatted Diff | Diff
Patch for landing (64.34 KB, patch)
2013-07-10 13:57 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-07-08 09:39:02 PDT 
Reduce number of header includes in SVG. In particular, SVGAnimatedPropertyMacros.h
no longer brings SVGElement.h header include. This means that the SVGElement
class can now have animated properties.

This patch is a prerequirement to merge SVGStyledElement into SVGElement.

Corresponding blink commit:
https://src.chromium.org/viewvc/blink?view=rev&revision=153682
Comment 1 Chris Dumez 2013-07-09 03:38:42 PDT 
Created attachment 206302 [details]
Patch
Comment 2 Chris Dumez 2013-07-09 03:41:31 PDT 
Created attachment 206303 [details]
Patch
Comment 3 Early Warning System Bot 2013-07-09 03:47:56 PDT 
Comment on attachment 206303 [details]
Patch

Attachment 206303 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/881642
Comment 4 EFL EWS Bot 2013-07-09 03:48:49 PDT 
Comment on attachment 206303 [details]
Patch

Attachment 206303 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1029312
Comment 5 Early Warning System Bot 2013-07-09 03:49:38 PDT 
Comment on attachment 206303 [details]
Patch

Attachment 206303 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1025751
Comment 6 EFL EWS Bot 2013-07-09 03:55:34 PDT 
Comment on attachment 206303 [details]
Patch

Attachment 206303 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/963919
Comment 7 Chris Dumez 2013-07-09 03:56:57 PDT 
Created attachment 206304 [details]
Patch
Comment 8 Rob Buis 2013-07-10 13:52:11 PDT 
Comment on attachment 206304 [details]
Patch

LGTM.
Comment 9 Chris Dumez 2013-07-10 13:57:34 PDT 
Created attachment 206412 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2013-07-10 16:49:31 PDT 
Comment on attachment 206412 [details]
Patch for landing

Clearing flags on attachment: 206412

Committed r152553: <http://trac.webkit.org/changeset/152553>
Comment 11 WebKit Commit Bot 2013-07-10 16:49:34 PDT 
All reviewed patches have been landed.  Closing bug.