Bug 103723 - [EFL] Volume control unable to show when preload="none" and src file is remote
Summary: [EFL] Volume control unable to show when preload="none" and src file is remote
Status: RESOLVED DUPLICATE of bug 106178
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Major
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-30 01:41 PST by Halton Huo
Modified: 2013-01-11 08:39 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.53 KB, patch)
2012-12-27 22:05 PST, Halton Huo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Halton Huo 2012-11-30 01:41:14 PST
Build EFL port on trunk@136087 and run MiniBrowser to access http://www.webmfiles.org/demo-files/, the volume control unable to show whatever preview and playing.

The related html code is:
<video width="560" height="320" controls="controls" preload="none"><source src="http://video.webmfiles.org/big-buck-bunny_trailer.webm" type="video/webm"></video>

I dump the page locally and do changes
* remove preload="none", then bug disappear
* download webm file to local and change src point to local, the volume control shows up after click play, the preview still show no volume control. 

Another message is when this bug happens, there is error on console:
ERR<16772>:ecore ecore_main.c:1509 _ecore_main_fd_handlers_bads_rem() Removing bad fds
ERR<16772>:ecore ecore_main.c:1551 _ecore_main_fd_handlers_bads_rem() No bad fd found. Maybe a foreign fd from glib?

I'll continue to dig out the root cause.
Comment 1 Halton Huo 2012-12-27 22:05:25 PST
Created attachment 180846 [details]
Patch
Comment 2 Gyuyoung Kim 2012-12-27 22:15:55 PST
Comment on attachment 180846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180846&action=review

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:-1084
> -    return (part != MediaMuteButtonPart);

Bug 97574 implemented this function before. https://bugs.webkit.org/show_bug.cgi?id=97574#c0

Did you test this case ?

- media/video-no-audio.html
Comment 3 Halton Huo 2012-12-27 22:32:17 PST
(In reply to comment #2)
> Did you test this case ?
> 
> - media/video-no-audio.html
The mute/unmute button shows up, as well as GTK port. So my fix should be wrong solution, will continue to work out.
Comment 4 Kenneth Rohde Christiansen 2012-12-28 00:55:11 PST
Comment on attachment 180846 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=180846&action=review

> Source/WebCore/ChangeLog:9
> +
> +        Enable state handling for MediaMuteButtonPart so that mute/unmute button could always be shown.
> +

if it always should be shown why does the method then exist?
Comment 5 Halton Huo 2013-01-11 03:55:32 PST
With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug).

The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing.

Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. 

Ubuntu can follow the instruction at https://wiki.ubuntu.com/Novacut/GStreamer1.0. (libgstreamer1.0-dev and libgstreamer-plugins-base1.0-dev need to be installed also).
Comment 6 Chris Dumez 2013-01-11 04:02:09 PST
(In reply to comment #5)
> With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug).
> 
> The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing.
> 
> Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. 

The EFL port already builds with gstreamer 1.0. It is part of jhbuild.
Comment 7 Chris Dumez 2013-01-11 04:11:57 PST
(In reply to comment #6)
> (In reply to comment #5)
> > With my fix for GTK bug #106436, I suppose GTK build will have same issue. But I'm wrong(GTK does not meet this bug).
> > 
> > The audioTracks in (https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp#L639) is always 0 with gstreamer 0.10 even start playing. With GTK build(gstreamer 1.0), audioTracks will bigger than 0 if start playing.
> > 
> > Now I'm guessing this is bug for gstreamer0.10. Now I'm trying to build EFL port with gstreamer1.0. 
> 
> The EFL port already builds with gstreamer 1.0. It is part of jhbuild.

Just pull later trunk and pass "--update-efl" to the build-webkit script. It will pull and build gstreamer 1.0.
Comment 8 Halton Huo 2013-01-11 08:39:12 PST
Yes, this bug disappear with trunk@139434, so close as dup of bug #106178

*** This bug has been marked as a duplicate of bug 106178 ***