With code trunk@138776, test LayoutTests/media/video-no-audio.html, the volume control will shown which is not expected. The same thing need to be done as EFL bug #97574.
Created attachment 181888 [details] Patch
The controls are being reworked in bug 83869. Not sure this patch makes sense meanwhile. Xabier, what do you think?
I talked to Jon Mccann and he says that the best would be showing the mute icon and show a "no audio" tooltip when hovering the button. So I guess this will be deeply reworked. I guess it will still take some time until we finish the controls, so we could push it as a temporary solution if it does not break any test, of course.
trunk@139575 still can not pass media/video-no-audio.html, while PASS with patch #181888.
Are you sure no rebaseline of the test is needed?
(In reply to comment #5) > Are you sure no rebaseline of the test is needed? Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher.
(In reply to comment #6) > (In reply to comment #5) > > Are you sure no rebaseline of the test is needed? > Just conflict on WebCore/GNUmakefile.list.am, easy to resolve. > > Actually with patch for bug 83869, the DumpRenderTree will crash when run-webkit-tests LayoutTests/media/video-no-audio.html, but PASS with run-launcher. Patch for bug 83869 is under high development, so you cannot trust it yet.
(In reply to comment #7) > Patch for bug 83869 is under high development, so you cannot trust it yet. Yes, I know, Philippe's comment made me to try whether the working bug 83869 will fix or hide this bug. I just give my try.
Ping, anyone could continue review on it?
Comment on attachment 181888 [details] Patch Clearing flags on attachment: 181888 Committed r140339: <http://trac.webkit.org/changeset/140339>
All reviewed patches have been landed. Closing bug.