Bug 97574 - [EFL] Volume button should not be shown for videos without audio
Summary: [EFL] Volume button should not be shown for videos without audio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 97671
Blocks:
  Show dependency tree / graph
 
Reported: 2012-09-25 10:24 PDT by Chris Dumez
Modified: 2012-09-26 12:43 PDT (History)
8 users (show)

See Also:

Attachments
Patch (60.50 KB, patch)
2012-09-26 09:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2012-09-25 10:24:08 PDT 
The EFL port currently display the volume button even if the video being played does not have an audio track.
We should fix this to unskip:
media/video-no-audio.html
Comment 1 Chris Dumez 2012-09-26 05:29:07 PDT 
This is an easy fix. Unfortunately, I identified flakiness in media controls styling and I'm still trying to debug that.
Comment 2 Chris Dumez 2012-09-26 09:13:27 PDT 
Created attachment 165820 [details]
Patch
Comment 3 Kenneth Rohde Christiansen 2012-09-26 12:30:55 PDT 
Comment on attachment 165820 [details]
Patch

Oh that theming.,,
Comment 4 WebKit Review Bot 2012-09-26 12:43:04 PDT 
Comment on attachment 165820 [details]
Patch

Clearing flags on attachment: 165820

Committed r129687: <http://trac.webkit.org/changeset/129687>
Comment 5 WebKit Review Bot 2012-09-26 12:43:09 PDT 
All reviewed patches have been landed.  Closing bug.