RESOLVED FIXED 106178
[EFL] Add gstreamer 1.0.5 to jhbuild 
https://bugs.webkit.org/show_bug.cgi?id=106178
Summary [EFL] Add gstreamer 1.0.5 to jhbuild
Chris Dumez
Reported 2013-01-05 07:33:37 PST
<http://trac.webkit.org/changeset/138786> ported the webaudio backend to gstreamer 1.0.4. Ubuntu 12.04 is shipping gstreamer 0.10.x so we need to add gstreamer 1.0.4 to jhbuild.
Attachments
Patch (12.48 KB, patch)
2013-01-08 10:25 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (15.28 KB, patch)
2013-01-09 04:09 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-01-05 10:58:12 PST
Apparently, this is not required so let's fix the regression with gstreamer 0.10 instead.
Chris Dumez
Comment 2 2013-01-08 02:21:49 PST
Reopening since it seems we may need it soon after all, based on the mailing list discussion.
Chris Dumez
Comment 3 2013-01-08 10:25:42 PST
Created attachment 181705 [details] Patch
Chris Dumez
Comment 4 2013-01-08 10:27:24 PST
We should make sure the following packages are installed on the bot due to avoid Bug 104792: libtheora-dev libvorbis-dev libfaad-dev
Philippe Normand
Comment 5 2013-01-08 10:31:54 PST
Have you checked the media tests? I haven't had time to check the 1.0.5 release yet
Chris Dumez
Comment 6 2013-01-08 10:53:04 PST
Comment on attachment 181705 [details] Patch You are right, there are a few regressions in media tests (webaudio tests seem fine though). I'll give gstreamer 1.0.4 a try.
Chris Dumez
Comment 7 2013-01-09 04:09:10 PST
Created attachment 181893 [details] Patch Improved patch: - Skips a few media tests that started crashing with gstreamer 1.0 - Force several gstreamer plugins to be built in jhbuild since they are required by LayoutTests
Laszlo Gombos
Comment 8 2013-01-09 14:31:19 PST
Comment on attachment 181893 [details] Patch Looks good to me. Thanks !
Chris Dumez
Comment 9 2013-01-10 00:38:53 PST
Comment on attachment 181893 [details] Patch I installed the right packages on the build bots, we should be good to go. I'll carefully watch the bots when it lands though.
WebKit Review Bot
Comment 10 2013-01-10 00:44:05 PST
Comment on attachment 181893 [details] Patch Clearing flags on attachment: 181893 Committed r139291: <http://trac.webkit.org/changeset/139291>
WebKit Review Bot
Comment 11 2013-01-10 00:44:10 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 12 2013-01-10 02:55:35 PST
I updated the build dependencies in https://trac.webkit.org/wiki/EFLWebKit We no longer need "libgstreamer0.10-dev libgstreamer-plugins-base0.10-dev" since it is part of jhbuild but we now need the following packages to build gstreamer 1.0: "libtheora-dev libvorbis-dev libfaad-dev libpulse-dev".
Chris Dumez
Comment 13 2013-01-10 03:29:16 PST
Hmm. Everything went fine on the debug build bot and the release one is getting timeouts for all media tests. I checked the output and it appears that the gstreamer pulse plugin was not built. I'm not sure why yet as I installed libpulse-dev package already.
Chris Dumez
Comment 14 2013-01-10 04:35:40 PST
(In reply to comment #13) > Hmm. Everything went fine on the debug build bot and the release one is getting timeouts for all media tests. I checked the output and it appears that the gstreamer pulse plugin was not built. I'm not sure why yet as I installed libpulse-dev package already. - The issue on the WK2 Release build bot was related to pulseaudio being in an error state and not running. We solved that. - The issue on the WK1 Release build bot is due to missing gstreamer dependencies on the build bot. I asked gyuyoung to take care of it.
Halton Huo
Comment 15 2013-01-11 08:39:12 PST
*** Bug 103723 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.