Summary: | [Gtk] Add Battery Status API support | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | José Dapena Paz <jdapena> | ||||
Component: | WebKitGTK | Assignee: | José Dapena Paz <jdapena> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, changseok, gustavo, jdapena, mrobinson, philn, webkit.review.bot, xan.lopez, zan | ||||
Priority: | P2 | Keywords: | Gtk, LayoutTestFailure | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 95937, 115628, 115718, 115719, 115720, 125453 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
José Dapena Paz
2012-08-31 09:09:22 PDT
Created attachment 162059 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 162059 [details] Patch Attachment 162059 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13743569 Comment on attachment 162059 [details] Patch Attachment 162059 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13757285 Comment on attachment 162059 [details] Patch Attachment 162059 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13739629 Comment on attachment 162059 [details] Patch Attachment 162059 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13744616 Can we get this work moving again? I can help if help is needed. Comment on attachment 162059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162059&action=review > Source/WebCore/ChangeLog:13 > + Test are disabled, as there is a linking issue related to > + WebCoreInternals. It'd be nice to figure this issue out. Also, not sure we want to add new features in WK1 at this point :/ Comment on attachment 162059 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162059&action=review The specification is a candidate recommendation so I think it would be great if we can get the implementation up and working. >> Source/WebCore/ChangeLog:13 >> + WebCoreInternals. > > It'd be nice to figure this issue out. Also, not sure we want to add new features in WK1 at this point :/ I think this is simply a matter of exporting the undefined symbols, nothing uncommon really. (In reply to comment #9) > The specification is a candidate recommendation so I think it would be great if we can get the implementation up and working. > Link to the specification: http://www.w3.org/TR/battery-status/ Oops. I didn't notice this movement supporting BatteryStatus before.. :p What's going on this? I've also worked a patch for this feature. If you guys don't mind, I'd like to post my patch somewhere. :) Shame about the duplicated work. My set of patches is complete, but still requires reviewing. The patches are spread in the bugs that are blocking this one. Aaand it's done. (In reply to comment #13) > Aaand it's done. Zan, great works! :) |