Bug 94798 – [EFL] Skip the tests which have wrong pixel expectations in fast/forms/

• Component: WebKit EFL
• Status: RESOLVED FIXED

[KwangYong Choi]

fast/forms/listbox-hit-test-zoomed.html
Test 2 in this test seems to fail.

fast/forms/menulist-restrict-line-height.html
The text in the popup button is clipped.

fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
Cancel mark in search field is not working.

fast/forms/menulist-narrow-width.html
fast/forms/select-baseline.html
fast/forms/menulist-style-color.html
fast/forms/select-style.html
These tests seem to have style error.

fast/forms/textarea-scroll-height.html
fast/forms/textarea-scrolled-type.html
Scroll bar isn't being fully rendered.

[Dominik Röttsches (drott)]

(In reply to comment #0)

> fast/forms/menulist-narrow-width.html
> fast/forms/select-baseline.html
> fast/forms/menulist-style-color.html
> fast/forms/select-style.html
> These tests seem to have style error.

Might be related do bug 85877.

[KwangYong Choi]

Created attachment 160133 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 160133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160133&action=review

> LayoutTests/ChangeLog:6
> +        Reviewed. Some tests in fast/forms seem to fail. Removed wrong expectations

s/Reviewed/Unreviewed/g

[KwangYong Choi]

Created attachment 160145 [details]
Patch

Reviewed -> Unreviewed

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 160145 [details]
Patch

First of all, you should create proper bug reports for all these different failures. This bug is about changing TestExpectations and removing a few baselines; once these changes are committed, the bug will be automatically closed and pointing to it from TestExpectations makes little sense.

Furthermore, I don't see why you are SKIPping these tests, as this means they will never be run.

[KwangYong Choi]

(In reply to comment #5)
> (From update of attachment 160145 [details])
> First of all, you should create proper bug reports for all these different failures. This bug is about changing TestExpectations and removing a few baselines; once these changes are committed, the bug will be automatically closed and pointing to it from TestExpectations makes little sense.

You're right. I'll make separate bugs by failure cases.

> 
> Furthermore, I don't see why you are SKIPping these tests, as this means they will never be run.

This topic is discussed on bug 94781 before. The reason why I make them skipped is because the right expectations are not exist. It means it cannot be passed without changing expectations. All the tests here should have their own platform expectations. So, I removed wrong files and make them skipped.

I think there are two kinds of test failures.

One is the test has common expectation. This should marked expected fail on TestExpectations. The result will be changed to 'expected failure, but pass' if it is changed later.

The other is the test has platform specific expectation. It means, we can not generate the right expectation for now. Until now, I think I have to remove wrong expectation and make it skipped. But, to do like this, we can not tracking the test result changes. So, I think, the result should be changed to current status one. How about this?

[KwangYong Choi]

(In reply to comment #0)
> fast/forms/listbox-hit-test-zoomed.html
> Test 2 in this test seems to fail.
> 
https://bugs.webkit.org/show_bug.cgi?id=94877

> fast/forms/menulist-restrict-line-height.html
> The text in the popup button is clipped.
> 
https://bugs.webkit.org/show_bug.cgi?id=94878

> fast/forms/search-cancel-button-style-sharing.html
> fast/forms/search-rtl.html
> Cancel mark in search field is not working.
https://bugs.webkit.org/show_bug.cgi?id=94880

> 
> fast/forms/menulist-narrow-width.html
> fast/forms/select-baseline.html
> fast/forms/menulist-style-color.html
> fast/forms/select-style.html
> These tests seem to have style error.
Mentioned by comment on bug 85877.
> 
> fast/forms/textarea-scroll-height.html
> fast/forms/textarea-scrolled-type.html
> Scroll bar isn't being fully rendered.
Mentioned by comment on bug 85484.

[Gyuyoung Kim]

Comment on attachment 160145 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160145&action=review

> LayoutTests/platform/efl/TestExpectations:914
> +BUGWK94798 SKIP : fast/forms/listbox-hit-test-zoomed.html = MISSING

According to TestExpectations doc, SKIP keyword can be used when below cases,

Use SKIP when the test:
- throws JavaScript exception and makes text-only test manifest as pixel-test. This usually manifests in "Missing test expectations" failure.
- disrupts running of the other tests. Although this is not typical, it may still be possible. Please make sure to give Pri-1 to the associated bug.

I'm not sure this failing test cases are adjusted this rule.

> LayoutTests/platform/efl/TestExpectations:917
> +BUGWK94798 SKIP : fast/forms/menulist-restrict-line-height.html = MISSING

You have to file a bug for this issue, then use created bug number.

[KwangYong Choi]

Created attachment 160326 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160326 [details]
Patch

Clearing flags on attachment: 160326

Committed r126541: <http://trac.webkit.org/changeset/126541>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.