Bug 94880 - [EFL] Cancel mark on search field is not displayed
Summary: [EFL] Cancel mark on search field is not displayed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-23 17:30 PDT by KwangYong Choi
Modified: 2013-03-18 03:15 PDT (History)
6 users (show)

See Also:


Attachments
Patch (76.16 KB, patch)
2013-03-15 01:19 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (76.12 KB, patch)
2013-03-18 03:00 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KwangYong Choi 2012-08-23 17:30:25 PDT
fast/forms/search-cancel-button-style-sharing.html
fast/forms/search-rtl.html
Cancel mark in search field is not displayed.
Comment 1 Gyuyoung Kim 2013-03-15 01:19:42 PDT
Created attachment 193256 [details]
Patch
Comment 2 Gyuyoung Kim 2013-03-17 19:26:32 PDT
CC'ing Laszlo and Chris, could you guys take a look this ?
Comment 3 Chris Dumez 2013-03-17 23:46:56 PDT
Comment on attachment 193256 [details]
Patch

LGTM.
Comment 4 WebKit Review Bot 2013-03-18 02:22:18 PDT
Comment on attachment 193256 [details]
Patch

Rejecting attachment 193256 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', '--bot-id=gce-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 193256, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
-- saving rejects to file LayoutTests/platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt.rej
patching file LayoutTests/platform/efl/fast/forms/search-rtl-expected.txt
Hunk #1 FAILED at 19.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/efl/fast/forms/search-rtl-expected.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Kenneth Rohde Christiansen']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://webkit-commit-queue.appspot.com/results/17236074
Comment 5 Gyuyoung Kim 2013-03-18 03:00:12 PDT
Created attachment 193511 [details]
Patch for landing
Comment 6 Gyuyoung Kim 2013-03-18 03:15:40 PDT
Comment on attachment 193511 [details]
Patch for landing

Clearing flags on attachment: 193511

Committed r146050: <http://trac.webkit.org/changeset/146050>
Comment 7 Gyuyoung Kim 2013-03-18 03:15:49 PDT
All reviewed patches have been landed.  Closing bug.