Bug 85484 – [EFL] Tracking corner not being painted for TextArea

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebKit EFL

[Thiago Marcos P. Santos]

Created attachment 139995 [details]
Current buggy rendering result

Neither is possible to resize by dragging the corner of the widget.

[Dominik Röttsches (drott)]

failing:
BUGWK85484 : fast/css/resize-corner-tracking-transformed.html = TEXT
BUGWK85484 : fast/css/resize-corner-tracking.html = TEXT

[Jussi Kukkonen (jku)]

Results from a quick look: This happens because corner handle size comes from scrollbar thickness and the efl scrollbar says it has a thickness 0. It looks like the reason for this is efls special 'overlay scrollbar' implementation that just paints on top of the scrollable... I bet this is related to other scrollbar bugs as well: e.g. text gets selected when you drag the scrollbar (should probably write a test case for that).

I think there's a proper way to do overlay scrollbars (at least the concept exists in webcore), I'll take a look at that. Comments from efl scrollbar experts welcome as well.

[Jussi Kukkonen (jku)]

Huh, it looks like it Just Works with a simple 
  usesOverlayScrollbars() const { return true; }
plus returning a proper width in scrollbarThickness(). I'll test a bit more and make a patch.

[Jussi Kukkonen (jku)]

Created attachment 145302 [details]
Patch

[Jussi Kukkonen (jku)]

(In reply to comment #4)
> Created an attachment (id=145302) [details]
> Patch

This seems to work, also fixes bug 87950.

* Includes a magic number for thickness: if there's a way to query scrollbar thickness from ScrollbarThemeEfl, please let me know. 

* I'm not sure the current thickness value is pixel-perfect: someone with more .edc experience could probably tell me...

* there's no graphic for the resize handle.

Any comments/advice on those are appreciated.

[Gyuyoung Kim]

Comment on attachment 145302 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=145302&action=review

(In reply to comment #5)
 
> * I'm not sure the current thickness value is pixel-perfect: someone with more .edc experience could probably tell me...

EFL port hasn't supported pixel test. So, we started to support pixel test in Bug 94188. I think this patch also should support pixel-test as well as layout test. But, too many tests aren't supported by pixel test in EFL port now. So, it may be difficult to find which tests are influenced by this patch. If so, in my opinion, this problem can be handled by a new bug linked to Bug 94188. Any other opinions? 

BTW, are there any differences in layout test ?

> Source/WebCore/platform/efl/ScrollbarThemeEfl.cpp:52
> +    return thickness;

If thickness variable is not used by other functions, it seems return 8; with comment is enough.
http://trac.webkit.org/browser/trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp#L817

[KwangYong Choi]

fast/forms/textarea-scroll-height.html
fast/forms/textarea-scrolled-type.html

Scroll bar isn't being fully rendered.

[Michael Catanzaro]

Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.