Bug 85877 - [EFL][DRT] Intrusive Theming overrides collide with style-related LayoutTests
Summary: [EFL][DRT] Intrusive Theming overrides collide with style-related LayoutTests
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 85494 91952
Blocks: 85484 85497 85603
  Show dependency tree / graph
 
Reported: 2012-05-08 02:50 PDT by Dominik Röttsches (drott)
Modified: 2017-03-11 10:38 PST (History)
10 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Röttsches (drott) 2012-05-08 02:50:07 PDT 
RenderThemeEfl.cpp aggresively overrides style on certain elements in the ::adjust* methods, for example:
::adjustTextFieldStyle() overrides:
    adjustSizeConstraints(style, TextField);
    style->resetBorder();
    style->setWhiteSpace(PRE);
    style->setColor(m_entryTextForegroundColor);
    style->setBackgroundColor(m_entryTextBackgroundColor);

This causes bug 85497, bug 85603, bug 85484.

I think we should less aggressively override the styles with theming here and make these cases pass instead. Feedback welcome.
Comment 1 Gustavo Sverzut Barbieri 2012-07-31 07:17:13 PDT 
Totally agreed.

When we first wrote RenderThemeEfl.cpp we based it on Gtk and Qt, not really something we desired to have, very likely similar to what was in these other ports at the time.
Comment 2 KwangYong Choi 2012-08-23 17:19:27 PDT 
For the information,

fast/forms/menulist-narrow-width.html
fast/forms/select-baseline.html
fast/forms/menulist-style-color.html
fast/forms/select-style.html

These tests seem to have similar style error.
Comment 3 Michael Catanzaro 2017-03-11 10:38:49 PST 
Closing this bug because the EFL port has been removed from trunk.

If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.