Bug 94781 – [EFL] Added missing SKIP keyword to platform/efl/TestExpectations

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[KwangYong Choi]

[EFL] Added missing SKIP keyword to platform/efl/TestExpectations

[KwangYong Choi]

Created attachment 160091 [details]
Patch

[Chris Dumez]

Comment on attachment 160091 [details]
Patch

Why do they need to be skipped? We should avoid skipping as much as possible (otherwise, we won't be able to see if the test starts passing later).

[KwangYong Choi]

(In reply to comment #2)
> (From update of attachment 160091 [details])
> Why do they need to be skipped? We should avoid skipping as much as possible (otherwise, we won't be able to see if the test starts passing later).

They have no common expectations, so they should not be passed. It can not be happen the test starts passing later without adding expectations. Someone should make the expectations for EFL when the feature is implemented or the feature is working well.

The reason why I try to add SKIP keyword is because I don't want to make the expectations during layout test. I should remove expectations every time I run the test. Otherwise, these test will pass because of their generated expectations.

[Gyuyoung Kim]

Comment on attachment 160091 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160091&action=review

> LayoutTests/ChangeLog:6
> +        Unreviewed gardening.

This is not gardening. Just mention "Unreviewed. bla bla.. "

> LayoutTests/ChangeLog:8
> +        Some layout test which is expected missing should not make expected result file.

s/test/tests/g , s/is/are/g ?

[KwangYong Choi]

Created attachment 160098 [details]
Patch

Applied Gyuyoung mentioned.

[Gyuyoung Kim]

Comment on attachment 160098 [details]
Patch

I think Kwangyong comment makes more sence. So, cq+

[WebKit Review Bot]

Comment on attachment 160098 [details]
Patch

Clearing flags on attachment: 160098

Committed r126403: <http://trac.webkit.org/changeset/126403>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Gyuyoung Kim]

Kwangyong, there is no *SKIP* keyword for MISSING expected result in TestExpectations files. If you wanna use SKIP keyword, this test can be moved to Skip file again. Anyway, I think this patch needs to be roll out. BTW, if these tests are expected PASS, it looks "= MISSING PASS" is better.

[KwangYong Choi]

(In reply to comment #9)
> Kwangyong, there is no *SKIP* keyword for MISSING expected result in TestExpectations files. If you wanna use SKIP keyword, this test can be moved to Skip file again. Anyway, I think this patch needs to be roll out. BTW, if these tests are expected PASS, it looks "= MISSING PASS" is better.

OK. I will follow your instruction. :)

[KwangYong Choi]

Created attachment 160343 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160343 [details]
Patch

Clearing flags on attachment: 160343

Committed r126565: <http://trac.webkit.org/changeset/126565>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.