| Summary: | [Qt] fast/table tests needs update after rebaseline and new testfonts | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Bruno Abinader (history only) <bruno.abinader> | ||||||||||||||
| Component: | WebKit Qt | Assignee: | Bruno Abinader (history only) <bruno.abinader> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | hausmann, igor.oliveira, menard, noam, ossy, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Bug Depends on: | 91570 | ||||||||||||||||
| Bug Blocks: | 85203, 91610, 91990 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Bruno Abinader (history only)
2012-07-18 06:16:11 PDT
Created attachment 153025 [details]
Proposed patch
Proposed patch
Comment on attachment 153025 [details]
Proposed patch
rs=me
Comment on attachment 153025 [details]
Proposed patch
rs=me
Created attachment 153027 [details]
Proposed patch (v2) - rebased to avoid conflicts
I've updated this patch as it might conflict with mainline due to old working tree of mine, now fixed.
Comment on attachment 153027 [details] Proposed patch (v2) - rebased to avoid conflicts Clearing flags on attachment: 153027 Committed r122985: <http://trac.webkit.org/changeset/122985> All reviewed patches have been landed. Closing bug. 4 new failing tests according to latest build: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/26755/steps/layout-test List of failing fast/table tests: fast/table/003.html = TEXT fast/table/colspanMinWidth.html = TEXT fast/table/spanOverlapRepaint.html = TEXT fast/table/text-field-baseline.html = TEXT Created attachment 153304 [details] Missing/Updated results patch This patch fixes the faulty results for fast/text directory after r122985. Created attachment 153310 [details]
Missing/Updated results patch (+ ChangeLog)
Yet another missing ChangeLog...
Comment on attachment 153310 [details]
Missing/Updated results patch (+ ChangeLog)
rs=me
Comment on attachment 153310 [details] Missing/Updated results patch (+ ChangeLog) Clearing flags on attachment: 153310 Committed r123229: <http://trac.webkit.org/changeset/123229> All reviewed patches have been landed. Closing bug. Setting status back to "reopened". Created attachment 154673 [details]
Re-skip and remove added tests on WK2 platform
This patch removes and re-skips the added tests for qt-5.0-wk2 layout test platform directory. As discussed with Caio, these tests should be assigned to proper bugs instead.
Comment on attachment 154673 [details]
Re-skip and remove added tests on WK2 platform
ok
Comment on attachment 154673 [details] Re-skip and remove added tests on WK2 platform Rejecting attachment 154673 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt' rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png' patching file LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13345832 This patch should be merged after bug 91570 patch, as it touches the same Skipped file. Can you please take a look there as well? Comment on attachment 154673 [details] Re-skip and remove added tests on WK2 platform Noam granted r/cq flags to bug 91570, so requesting cq again for this. Comment on attachment 154673 [details] Re-skip and remove added tests on WK2 platform Rejecting attachment 154673 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt' rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png' patching file LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13342899 Created attachment 154703 [details] Re-skip and remove added tests on WK2 platform (v2) Rebased. Please notice this patch should land _after_ patch from bug 91570. Comment on attachment 154703 [details] Re-skip and remove added tests on WK2 platform (v2) Removing "cq" flag, as corrected by Alexis, until patch from bug 91570 gets landed. Igor landed the patch manually, marking as "fixed". |