Bug 91621

Summary:

[Qt] fast/table tests needs update after rebaseline and new testfonts

Product:

WebKit

Reporter:

Bruno Abinader (history only) <bruno.abinader>

Component:

WebKit Qt

Assignee:

Bruno Abinader (history only) <bruno.abinader>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, igor.oliveira, menard, noam, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

91570

Bug Blocks:

85203, 91610, 91990

Attachments:

Description	Flags
Proposed patch	none
Proposed patch (v2) - rebased to avoid conflicts	none
Missing/Updated results patch	none
Missing/Updated results patch (+ ChangeLog)	none
Re-skip and remove added tests on WK2 platform	kenneth: review+, webkit.review.bot: commit-queue-
Re-skip and remove added tests on WK2 platform (v2)	noam: review+

Bruno Abinader (history only)

Reported 2012-07-18 06:16:11 PDT

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use 'monospace' font when directed, fast/table tests directory needs to be updated.

Attachments
Proposed patch (deleted) 2012-07-18 09:12 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Proposed patch (v2) - rebased to avoid conflicts (deleted) 2012-07-18 09:21 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Missing/Updated results patch (101.91 KB, patch) 2012-07-19 10:48 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Missing/Updated results patch (+ ChangeLog) (103.33 KB, patch) 2012-07-19 11:03 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Re-skip and remove added tests on WK2 platform (47.71 KB, patch) 2012-07-26 09:47 PDT, Bruno Abinader (history only)	kenneth: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Re-skip and remove added tests on WK2 platform (v2) (47.71 KB, patch) 2012-07-26 11:32 PDT, Bruno Abinader (history only)	noam: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Bruno Abinader (history only)

Comment 1 2012-07-18 09:12:59 PDT

Created attachment 153025 [details] Proposed patch Proposed patch

Alexis Menard (darktears)

Comment 2 2012-07-18 09:18:32 PDT

Comment on attachment 153025 [details] Proposed patch rs=me

Alexis Menard (darktears)

Comment 3 2012-07-18 09:21:00 PDT

Comment on attachment 153025 [details] Proposed patch rs=me

Bruno Abinader (history only)

Comment 4 2012-07-18 09:21:00 PDT

Created attachment 153027 [details] Proposed patch (v2) - rebased to avoid conflicts I've updated this patch as it might conflict with mainline due to old working tree of mine, now fixed.

WebKit Review Bot

Comment 5 2012-07-18 10:30:16 PDT

Comment on attachment 153027 [details] Proposed patch (v2) - rebased to avoid conflicts Clearing flags on attachment: 153027 Committed r122985: <http://trac.webkit.org/changeset/122985>

WebKit Review Bot

Comment 6 2012-07-18 10:30:21 PDT

All reviewed patches have been landed. Closing bug.

Bruno Abinader (history only)

Comment 7 2012-07-19 09:15:31 PDT

4 new failing tests according to latest build: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/26755/steps/layout-test List of failing fast/table tests: fast/table/003.html = TEXT fast/table/colspanMinWidth.html = TEXT fast/table/spanOverlapRepaint.html = TEXT fast/table/text-field-baseline.html = TEXT

Bruno Abinader (history only)

Comment 8 2012-07-19 10:48:15 PDT

Created attachment 153304 [details] Missing/Updated results patch This patch fixes the faulty results for fast/text directory after r122985.

Bruno Abinader (history only)

Comment 9 2012-07-19 11:03:41 PDT

Created attachment 153310 [details] Missing/Updated results patch (+ ChangeLog) Yet another missing ChangeLog...

Noam Rosenthal

Comment 10 2012-07-20 10:21:30 PDT

Comment on attachment 153310 [details] Missing/Updated results patch (+ ChangeLog) rs=me

WebKit Review Bot

Comment 11 2012-07-20 10:48:03 PDT

Comment on attachment 153310 [details] Missing/Updated results patch (+ ChangeLog) Clearing flags on attachment: 153310 Committed r123229: <http://trac.webkit.org/changeset/123229>

WebKit Review Bot

Comment 12 2012-07-20 10:48:09 PDT

All reviewed patches have been landed. Closing bug.

Bruno Abinader (history only)

Comment 13 2012-07-26 09:47:05 PDT

Setting status back to "reopened".

Bruno Abinader (history only)

Comment 14 2012-07-26 09:47:59 PDT

Created attachment 154673 [details] Re-skip and remove added tests on WK2 platform This patch removes and re-skips the added tests for qt-5.0-wk2 layout test platform directory. As discussed with Caio, these tests should be assigned to proper bugs instead.

Kenneth Rohde Christiansen

Comment 15 2012-07-26 10:21:05 PDT

Comment on attachment 154673 [details] Re-skip and remove added tests on WK2 platform ok

WebKit Review Bot

Comment 16 2012-07-26 10:25:37 PDT

Comment on attachment 154673 [details] Re-skip and remove added tests on WK2 platform Rejecting attachment 154673 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/spanOverlapRepaint-expected.txt' rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.png' patching file LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt rm 'LayoutTests/platform/qt-5.0-wk2/fast/table/text-field-baseline-expected.txt' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kenneth Ro..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13345832

Bruno Abinader (history only)

Comment 17 2012-07-26 10:50:03 PDT

This patch should be merged after bug 91570 patch, as it touches the same Skipped file. Can you please take a look there as well?

Bruno Abinader (history only)

Comment 18 2012-07-26 11:03:18 PDT

Comment on attachment 154673 [details] Re-skip and remove added tests on WK2 platform Noam granted r/cq flags to bug 91570, so requesting cq again for this.

WebKit Review Bot

Comment 19 2012-07-26 11:20:52 PDT

Bruno Abinader (history only)

Comment 20 2012-07-26 11:32:34 PDT

Created attachment 154703 [details] Re-skip and remove added tests on WK2 platform (v2) Rebased. Please notice this patch should land _after_ patch from bug 91570.

Bruno Abinader (history only)

Comment 21 2012-07-26 11:52:21 PDT

Comment on attachment 154703 [details] Re-skip and remove added tests on WK2 platform (v2) Removing "cq" flag, as corrected by Alexis, until patch from bug 91570 gets landed.

Bruno Abinader (history only)

Comment 22 2012-07-26 15:44:03 PDT

Igor landed the patch manually, marking as "fixed".

Note You need to log in before you can comment on or make changes to this bug.