Bug 91570

Summary:

[Qt] fast/text tests needs update after rebaseline and new testfonts

Product:

WebKit

Reporter:

Bruno Abinader (history only) <bruno.abinader>

Component:

WebKit Qt

Assignee:

Bruno Abinader (history only) <bruno.abinader>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hausmann, igor.oliveira, menard, noam, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

85203, 91610, 91621, 91990

Attachments:

Description	Flags
Proposed patch	none
Missing/Updated results patch	none
Missing/Updated results patch (+ ChangeLog)	none
Missing/Updated results patch (v2)	none
Re-skip and remove added tests on WK2 platform	noam: review+, webkit.review.bot: commit-queue-
Re-skip and remove added tests on WK2 platform (v2)	none
Patch	none

Bruno Abinader (history only)

Reported 2012-07-17 19:01:55 PDT

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use 'monospace' font when directed, fast/text tests directory needs to be updated.

Attachments
Proposed patch (deleted) 2012-07-18 06:08 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Missing/Updated results patch (48.63 KB, patch) 2012-07-19 10:25 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Missing/Updated results patch (+ ChangeLog) (50.15 KB, patch) 2012-07-19 10:26 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Missing/Updated results patch (v2) (50.15 KB, patch) 2012-07-19 10:44 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Re-skip and remove added tests on WK2 platform (32.11 KB, patch) 2012-07-26 09:26 PDT, Bruno Abinader (history only)	noam: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Re-skip and remove added tests on WK2 platform (v2) (32.03 KB, patch) 2012-07-26 11:29 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Patch (30.59 KB, patch) 2012-07-26 14:17 PDT, Bruno Abinader (history only)	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Bruno Abinader (history only)

Comment 1 2012-07-18 06:08:37 PDT

Created attachment 153001 [details] Proposed patch Proposed patch

Simon Hausmann

Comment 2 2012-07-18 07:27:12 PDT

Comment on attachment 153001 [details] Proposed patch rs=me

WebKit Review Bot

Comment 3 2012-07-18 07:55:16 PDT

Comment on attachment 153001 [details] Proposed patch Clearing flags on attachment: 153001 Committed r122971: <http://trac.webkit.org/changeset/122971>

WebKit Review Bot

Comment 4 2012-07-18 07:55:22 PDT

All reviewed patches have been landed. Closing bug.

Bruno Abinader (history only)

Comment 5 2012-07-19 09:14:38 PDT

3 new failing tests according to latest build: http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/26755/steps/layout-test List of failing fast/text tests: fast/text/international/unicode-bidi-plaintext-in-textarea.html = TEXT fast/text/textIteratorNilRenderer.html = TEXT fast/text/whitespace/030.html = TEXT I am having a double check at those atm.

Bruno Abinader (history only)

Comment 6 2012-07-19 10:25:09 PDT

Created attachment 153295 [details] Missing/Updated results patch This patch fixes the faulty results for fast/text directory after r122985.

Bruno Abinader (history only)

Comment 7 2012-07-19 10:26:42 PDT

Created attachment 153296 [details] Missing/Updated results patch (+ ChangeLog) Added missing ChangeLog.

Bruno Abinader (history only)

Comment 8 2012-07-19 10:44:55 PDT

Created attachment 153302 [details] Missing/Updated results patch (v2) Fixed commit message with proper bug url.

WebKit Review Bot

Comment 9 2012-07-19 13:20:46 PDT

Comment on attachment 153302 [details] Missing/Updated results patch (v2) Clearing flags on attachment: 153302 Committed r123144: <http://trac.webkit.org/changeset/123144>

WebKit Review Bot

Comment 10 2012-07-19 13:20:51 PDT

All reviewed patches have been landed. Closing bug.

Bruno Abinader (history only)

Comment 11 2012-07-26 09:26:07 PDT

Created attachment 154667 [details] Re-skip and remove added tests on WK2 platform This patch removes and re-skips the added tests for qt-5.0-wk2 layout test platform directory. As discussed with Caio, these tests should be assigned to proper bugs instead.

Bruno Abinader (history only)

Comment 12 2012-07-26 09:26:57 PDT

Changing status back to "reopened".

WebKit Review Bot

Comment 13 2012-07-26 11:19:41 PDT

Comment on attachment 154667 [details] Re-skip and remove added tests on WK2 platform Rejecting attachment 154667 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: fast/text/textIteratorNilRenderer-expected.txt rm 'LayoutTests/platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt' LayoutTests/platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: unknown git binary patch format at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 1912. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Noam Rosen..." exit_code: 29 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13353864

Bruno Abinader (history only)

Comment 14 2012-07-26 11:29:44 PDT

Created attachment 154698 [details] Re-skip and remove added tests on WK2 platform (v2) Rebased.

Bruno Abinader (history only)

Comment 15 2012-07-26 11:50:47 PDT

Comment on attachment 154698 [details] Re-skip and remove added tests on WK2 platform (v2) Removing review flag as corrected by Alexis.

WebKit Review Bot

Comment 16 2012-07-26 12:56:33 PDT

Comment on attachment 154698 [details] Re-skip and remove added tests on WK2 platform (v2) Rejecting attachment 154698 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ayoutTests/platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt rm 'LayoutTests/platform/qt-5.0-wk2/fast/text/textIteratorNilRenderer-expected.txt' LayoutTests/platform/qt-5.0/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: unknown git binary patch format at /mnt/git/webkit-commit-queue/Tools/Scripts/VCSUtils.pm line 1912. Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 29 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13347970

Bruno Abinader (history only)

Comment 17 2012-07-26 14:17:01 PDT

Created attachment 154746 [details] Patch

Bruno Abinader (history only)

Comment 18 2012-07-26 14:19:08 PDT

This time I´ve uploaded the patch using "webkit-patch" script, so in theory safer than generating through "git format-patch" and thus a hope against this weird "unknown git binary patch format" error message.

Bruno Abinader (history only)

Comment 19 2012-07-26 15:30:50 PDT

Comment on attachment 154746 [details] Patch Igor applied the patch manually.

Bruno Abinader (history only)

Comment 20 2012-07-26 15:31:09 PDT

Marking as "fixed".

Note You need to log in before you can comment on or make changes to this bug.