Bug 88210

Summary:

Expose layoutTestController as testRunner

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, jesus, jonlee, kpiascik, mitz, mjs, mxie, ojan, rakuco, rwlbuis, tkent, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

88755, 88757, 88761, 88766, 88769, 88955, 88959, 88969, 89176, 89181, 89182, 89184, 89262, 89263, 89422, 89431, 89438, 89445, 89462, 89654, 89662, 89741, 89744, 91315, 92898, 92944, 92947, 93172, 93173, 93176, 93177, 93184, 93758, 93942

Attachments:

Description	Flags
Patch	none
Added the forgotten WebKitTestRunner change	none

Description Ryosuke Niwa 2012-06-03 21:03:31 PDT

Expose layoutTestController as testRunner

Comment 1 Ryosuke Niwa 2012-06-03 21:08:42 PDT

Created attachment 145512 [details]
Patch

Comment 2 Darin Adler 2012-06-04 00:12:46 PDT

Comment on attachment 145512 [details]
Patch

Looks good for DumpRenderTree and TestShell, but to handle WebKitTestRunner, we also need a change to LayoutTestController::makeWindowObject in Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp. Since this adds a test, we’ll start seeing failures if you don’t add that, so review-.

Comment 3 Ryosuke Niwa 2012-06-04 00:43:43 PDT

(In reply to comment #2)
> (From update of attachment 145512 [details])
> Looks good for DumpRenderTree and TestShell, but to handle WebKitTestRunner, we also need a change to LayoutTestController::makeWindowObject in Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp. Since this adds a test, we’ll start seeing failures if you don’t add that, so review-.

Oops, I had that change in my mind and totally forgot about it. Uploading a new patch now.

Comment 4 Ryosuke Niwa 2012-06-04 00:44:29 PDT

Created attachment 145529 [details]
Added the forgotten WebKitTestRunner change

Comment 5 Ryosuke Niwa 2012-06-04 16:09:47 PDT

Ping reviewers.

Comment 6 Ryosuke Niwa 2012-06-10 13:48:13 PDT

Could someone review the patch?

Comment 7 Ryosuke Niwa 2012-06-10 14:28:11 PDT

Thanks! I'll land this, and start converting tests.

Comment 8 WebKit Review Bot 2012-06-10 14:36:47 PDT

Comment on attachment 145529 [details]
Added the forgotten WebKitTestRunner change

Clearing flags on attachment: 145529

Committed r119946: <http://trac.webkit.org/changeset/119946>

Comment 9 WebKit Review Bot 2012-06-10 14:36:52 PDT

All reviewed patches have been landed.  Closing bug.

Comment 10 Darin Adler 2012-06-10 19:04:04 PDT

Why doesn't this property get dumped and so show up in “all the properties of the window object” tests?

Comment 11 Ryosuke Niwa 2012-06-10 20:56:32 PDT

(In reply to comment #10)
> Why doesn't this property get dumped and so show up in “all the properties of the window object” tests?

Which test are you talking about? I thought we got rid of those dump-all-properties tests?