|
Description
Frédéric Wang (:fredw)
2012-05-06 07:53:01 PDT
Created attachment 274756 [details]
testcase
Here is another testcase.
Created attachment 274758 [details]
WIP Patch
Created attachment 274827 [details]
Patch
Comment on attachment 274827 [details] Patch Attachment 274827 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1031043 New failing tests: mathml/mathml-in-html5/href-click-2.html mathml/presentation/href-enter.html mathml/presentation/semantics-href.html mathml/mathml-in-html5/href-click-1.html Created attachment 274828 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.10.5
Created attachment 277387 [details]
Patch
Comment on attachment 277387 [details] Patch Attachment 277387 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1224254 New failing tests: imported/mathml-in-html5/mathml/relations/html5-tree/href-click-1.html mathml/presentation/href-enter.html mathml/presentation/semantics-href.html imported/mathml-in-html5/mathml/relations/html5-tree/href-click-2.html Created attachment 277392 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Created attachment 279005 [details]
Patch
Comment on attachment 279005 [details] Patch Attachment 279005 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1329435 New failing tests: imported/mathml-in-html5/mathml/relations/html5-tree/href-click-1.html mathml/presentation/semantics-href.html imported/mathml-in-html5/mathml/relations/html5-tree/href-click-2.html Created attachment 279010 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Created attachment 279013 [details]
Patch
Created attachment 282061 [details]
Patch
Comment on attachment 282061 [details] Patch Attachment 282061 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1567033 New failing tests: mathml/presentation/href-enter.html mathml/presentation/href-style.html Created attachment 282062 [details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 282061 [details] Patch Attachment 282061 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1567036 New failing tests: mathml/presentation/href-enter.html mathml/presentation/href-style.html Created attachment 282064 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 282061 [details] Patch Attachment 282061 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1567038 New failing tests: imported/mathml-in-html5/mathml/relations/html5-tree/href-click-1.html mathml/presentation/href-enter.html mathml/presentation/semantics-href.html imported/mathml-in-html5/mathml/relations/html5-tree/href-click-2.html Created attachment 282066 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.4
Comment on attachment 282061 [details] Patch Attachment 282061 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1567044 New failing tests: mathml/presentation/href-enter.html mathml/presentation/href-style.html Created attachment 282068 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
This change doesn't seem to work. Does it depend on any of your other MathML changes to work properly? Created attachment 283058 [details]
Patch
Mmh, it seems I'll have to check this again on Mac / iOS. Comment on attachment 283058 [details] Patch Attachment 283058 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1643217 New failing tests: mathml/presentation/href-enter.html mathml/presentation/href-style.html Created attachment 283072 [details]
Archive of layout-test-results from ews100 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 283058 [details] Patch Attachment 283058 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1643228 New failing tests: mathml/presentation/href-enter.html mathml/presentation/href-style.html Created attachment 283073 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 283058 [details] Patch Attachment 283058 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1643233 New failing tests: mathml/presentation/href-enter.html mathml/presentation/href-style.html Created attachment 283076 [details]
Archive of layout-test-results from ews116 for mac-yosemite
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Comment on attachment 283058 [details] Patch Attachment 283058 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1643239 New failing tests: mathml/presentation/href-enter.html Created attachment 283081 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Created attachment 283303 [details]
Patch
(In reply to comment #23) > This change doesn't seem to work. Does it depend on any of your other MathML > changes to work properly? The change still works and the basic tests from the MathML in HTML5 test suite pass. The problem was with these two more advanced tests mathml/presentation/href-enter.html mathml/presentation/href-style.html which use our test API to emulate keyboard navigation. They were skipped in the patch from mid May but it seems the change in TestExpectations were lost after later rebasing. Should be fixed now. Comment on attachment 283303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283303&action=review r=me. I suggest you file bugzillas for the two skip cases so we don't forget to investigate them. > Source/WebCore/mathml/MathMLElement.cpp:228 > + setNeedsStyleRecalc(); Should you be doing the DNS prefetch logic here, just like we do for HTMLAnchorElement? > Source/WebCore/mathml/MathMLElement.cpp:335 > + Frame* frame = document().frame(); Maybe better as: if (Frame* frame = document().frame()) frame->loader()...... return; > LayoutTests/platform/ios-simulator/TestExpectations:680 > +mathml/presentation/href-style.html [ Skip ] Is there a bugzilla for this problem? > LayoutTests/platform/mac/TestExpectations:810 > +mathml/presentation/href-style.html [ Skip ] Ditto. Comment on attachment 283303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283303&action=review >> Source/WebCore/mathml/MathMLElement.cpp:228 >> + setNeedsStyleRecalc(); > > Should you be doing the DNS prefetch logic here, just like we do for HTMLAnchorElement? Maybe someone who is more familiar with the code can comment but I believe we could land the patch without that, given that SVGAElement does not do that stuff either. (In reply to comment #37) > Comment on attachment 283303 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283303&action=review > > >> Source/WebCore/mathml/MathMLElement.cpp:228 > >> + setNeedsStyleRecalc(); > > > > Should you be doing the DNS prefetch logic here, just like we do for HTMLAnchorElement? > > Maybe someone who is more familiar with the code can comment but I believe > we could land the patch without that, given that SVGAElement does not do > that stuff either. It looks like the prefetch code is pretty old, so I guess SVG would have been updated to include it if it was extremely important. Let's just proceed with the code as-is. Committed r203104: <http://trac.webkit.org/changeset/203104> |