Bug 83811
| Summary: | Stop exposing RenderLayer knowledge to the code outside rendering/ | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Julien Chaffraix <jchaffraix> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | eric, fmalita, jamesr, krit, noam, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 83728, 83816, 84090, 84607 | ||
| Bug Blocks: | |||
Julien Chaffraix
Currently RenderLayer's getter is public (RenderBoxModelObject::layer()) which makes it convenient for people to start poking the layer. However this is hurting us as objects outside rendering have some very deep knowledge of how rendering is supposed to work. This breaks the rendering abstraction and makes it harder to refactor RenderLayer in many ways.
I haven't thought deeply on that but RenderObject::hasLayer() should likely be made protected too as this is an implementation detail.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
Sounds like a great idea to me.