Bug 67409

Summary: Consider Conditional attribute in CodeGenerator for methods
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 67397, 67403, 67406    
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-09-01 08:25:00 PDT
Consider Conditional attribute in CodeGeneratorJS for PrototypeFunction
Attachments
Patch (3.24 KB, patch)
2011-09-01 08:29 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (22.49 KB, patch)
2011-09-01 10:26 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-09-01 08:29:57 PDT
Created attachment 105970 [details] Patch
Darin Adler
Comment 2 2011-09-01 10:02:42 PDT
Comment on attachment 105970 [details] Patch You should add a binding test when you change how bindings work. You can run the bindings tests like this: run-bindings-tests You can generate new test results after changing the test input like this: run-bindings-tests --reset-results Your patch should include both changes to the test IDL files and the changes to the expected result files.
Patrick R. Gansterer
Comment 3 2011-09-01 10:26:12 PDT
Created attachment 105988 [details] Patch
WebKit Review Bot
Comment 4 2011-09-01 15:41:28 PDT
Comment on attachment 105988 [details] Patch Clearing flags on attachment: 105988 Committed r94354: <http://trac.webkit.org/changeset/94354>
WebKit Review Bot
Comment 5 2011-09-01 15:41:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.