Bug 65889

Summary: Implement <input type=color> UI behavior WebKit mac part
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Jon Lee <jonlee>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: annevk, jonlee, syoichi, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61276    
Attachments:
Description Flags
patch none

Keishi Hattori
Reported 2011-08-08 16:53:14 PDT
implement ChromeClient::openColorChooser, closeColorChooser, and setSelectedColorInColorChooser for WebKit mac
Attachments
patch (11.41 KB, patch)
2011-08-09 20:50 PDT, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2011-08-09 20:50:46 PDT
Created attachment 103437 [details] patch
Keishi Hattori
Comment 2 2011-08-25 05:43:04 PDT
Comment on attachment 103437 [details] patch Obsoleting patch. I will be changing the NSColorPanel behavior to match OS X.
Jon Lee
Comment 3 2012-02-01 12:12:28 PST
Is there a status update on this? Is there a way I can help, or take the bug?
Keishi Hattori
Comment 4 2012-02-01 17:19:12 PST
Right now I am trying to land the patch for the Chromium side. I tried to implement it for Safari but I have given up because it requires modifying Safari. Please take this bug :)
Jon Lee
Comment 5 2012-02-01 17:23:42 PST
Sure! I tried to enable INPUT_COLOR and it looks like there were some loose ends that didn't get checked in (like a missing virtual destructor in ColorChooserClient), aside from just impl'ing the client. Are those part of your patches that haven't been checked in yet, or are they part of another bug?
Keishi Hattori
Comment 6 2012-02-02 20:02:38 PST
(In reply to comment #5) > Sure! I tried to enable INPUT_COLOR and it looks like there were some loose ends that didn't get checked in (like a missing virtual destructor in ColorChooserClient), aside from just impl'ing the client. Are those part of your patches that haven't been checked in yet, or are they part of another bug? I've uploaded patches Bug 77698, Bug 77699, Bug 77701 to fix bugs I know about.
Anne van Kesteren
Comment 7 2023-12-29 01:09:27 PST
This control has been working for quite a while.
Note You need to log in before you can comment on or make changes to this bug.