Bug 59428

Summary: Enable strict mode for OwnPtr and PassOwnPtr
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, darin, dglazkov, eric, gustavo.noronha, gustavo, levin, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 59666, 59667, 59861, 59876, 59878, 59881, 59898    
Bug Blocks: 59909    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Adam Barth 2011-04-25 23:48:45 PDT 
Enable strict mode for OwnPtr
Comment 1 Adam Barth 2011-04-25 23:49:26 PDT 
Created attachment 91073 [details]
Patch
Comment 2 David Levin 2011-04-25 23:56:56 PDT 
Comment on attachment 91073 [details]
Patch

pending ews results.
Comment 3 WebKit Review Bot 2011-04-26 00:12:28 PDT 
Attachment 91073 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8509542
Comment 4 Early Warning System Bot 2011-04-26 00:19:32 PDT 
Attachment 91073 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8509543
Comment 5 Build Bot 2011-04-26 00:41:44 PDT 
Attachment 91073 [details] did not build on win:
Build output: http://queues.webkit.org/results/8506647
Comment 6 WebKit Review Bot 2011-04-26 00:55:45 PDT 
Attachment 91073 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8508569
Comment 7 Collabora GTK+ EWS bot 2011-04-26 03:01:40 PDT 
Attachment 91073 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8507579
Comment 8 Adam Barth 2011-04-27 13:40:17 PDT 
Created attachment 91337 [details]
Patch
Comment 9 David Levin 2011-04-27 13:41:34 PDT 
Comment on attachment 91337 [details]
Patch

This will make it easier for other ports to break the mac platform, but I guess it will get fixed quickly and it shouldn't happen too often.
Comment 10 Adam Barth 2011-04-27 13:55:51 PDT 
> This will make it easier for other ports to break the mac platform, but I guess it will get fixed quickly and it shouldn't happen too often.

Yeah, this is just an intermediate state.  We shouldn't linger here very long.
Comment 11 Adam Barth 2011-04-27 13:59:04 PDT 
Committed r85084: <http://trac.webkit.org/changeset/85084>
Comment 12 Adam Barth 2011-04-27 14:03:36 PDT 
Re-opening because we need to enable this on other platforms.
Comment 13 WebKit Review Bot 2011-04-27 14:19:02 PDT 
http://trac.webkit.org/changeset/85084 might have broken Leopard Intel Debug (Build)
Comment 14 Darin Adler 2011-04-27 14:41:49 PDT 
We also want to enable the strict mode for PassOwnPtr.
Comment 15 Adam Barth 2011-04-27 14:45:56 PDT 
(In reply to comment #14)
> We also want to enable the strict mode for PassOwnPtr.

Yep.  I'm testing compile for that one now.
Comment 16 David Levin 2011-04-27 19:29:28 PDT 
Comment on attachment 91337 [details]
Patch

Clearing r+ since it has been landed (to move out of the list to be committed).
Comment 17 Adam Barth 2011-05-01 17:33:22 PDT 
Created attachment 91860 [details]
Patch
Comment 18 Adam Barth 2011-05-01 17:33:50 PDT 
Committed r85445: <http://trac.webkit.org/changeset/85445>
Comment 19 Adam Barth 2011-05-01 18:02:54 PDT 
Comment on attachment 91860 [details]
Patch

Oh, well technically we didn't do strict PassOwnPtr, but that can be another bug.