Bug 59861 – Enable strict OwnPtr for GTK

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

Enable strict OwnPtr for GTK

[Adam Barth]

Created attachment 91795 [details]
Patch

[Collabora GTK+ EWS bot]

Attachment 91795 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8530025

[Martin Robinson]

Created attachment 91806 [details]
Updated patch

[Adam Barth]

Comment on attachment 91806 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91806&action=review

> Source/WebCore/page/Geolocation.cpp:220
> -    , m_service(GeolocationService::create(this))
> +    , m_service(adoptPtr(GeolocationService::create(this)))

Should GeolocationService::create return a PassOwnPtr instead?

> Source/WebCore/platform/graphics/cairo/PathCairo.cpp:56
> +    OwnPtr<cairo_path_t> pathCopy(adoptPtr(cairo_copy_path(other.platformPath()->context())));

We tend to prefer the assignment form of the constructor for OwnPtr.

[Martin Robinson]

Created attachment 91810 [details]
Patch

[Martin Robinson]

(In reply to comment #4)
> (From update of attachment 91806 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=91806&action=review

Thanks for the quick review.

> > Source/WebCore/page/Geolocation.cpp:220
> > -    , m_service(GeolocationService::create(this))
> > +    , m_service(adoptPtr(GeolocationService::create(this)))
> 
> Should GeolocationService::create return a PassOwnPtr instead?

Indeed it should. I've made this change and pushed the fixes down to all the GeolocationService factory methods.

> 
> > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:56
> > +    OwnPtr<cairo_path_t> pathCopy(adoptPtr(cairo_copy_path(other.platformPath()->context())));
> We tend to prefer the assignment form of the constructor for OwnPtr.

Fixed! I think I'll write an email to propose this for the style guide.

[WebKit Commit Bot]

Comment on attachment 91810 [details]
Patch

Clearing flags on attachment: 91810

Committed r85405: <http://trac.webkit.org/changeset/85405>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.