Enable strict OwnPtr for GTK
Created attachment 91795 [details] Patch
Attachment 91795 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8530025
Created attachment 91806 [details] Updated patch
Comment on attachment 91806 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=91806&action=review > Source/WebCore/page/Geolocation.cpp:220 > - , m_service(GeolocationService::create(this)) > + , m_service(adoptPtr(GeolocationService::create(this))) Should GeolocationService::create return a PassOwnPtr instead? > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:56 > + OwnPtr<cairo_path_t> pathCopy(adoptPtr(cairo_copy_path(other.platformPath()->context()))); We tend to prefer the assignment form of the constructor for OwnPtr.
Created attachment 91810 [details] Patch
(In reply to comment #4) > (From update of attachment 91806 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=91806&action=review Thanks for the quick review. > > Source/WebCore/page/Geolocation.cpp:220 > > - , m_service(GeolocationService::create(this)) > > + , m_service(adoptPtr(GeolocationService::create(this))) > > Should GeolocationService::create return a PassOwnPtr instead? Indeed it should. I've made this change and pushed the fixes down to all the GeolocationService factory methods. > > > Source/WebCore/platform/graphics/cairo/PathCairo.cpp:56 > > + OwnPtr<cairo_path_t> pathCopy(adoptPtr(cairo_copy_path(other.platformPath()->context()))); > We tend to prefer the assignment form of the constructor for OwnPtr. Fixed! I think I'll write an email to propose this for the style guide.
Comment on attachment 91810 [details] Patch Clearing flags on attachment: 91810 Committed r85405: <http://trac.webkit.org/changeset/85405>
All reviewed patches have been landed. Closing bug.