Bug 59878 - Fix OwnPtr strict issues in windows build
Summary: Fix OwnPtr strict issues in windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 59428
  Show dependency tree / graph
 
Reported: 2011-05-01 10:10 PDT by Patrick R. Gansterer
Modified: 2011-05-01 10:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (14.62 KB, patch)
2011-05-01 10:12 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-05-01 10:10:12 PDT 
see patch
Comment 1 Patrick R. Gansterer 2011-05-01 10:12:39 PDT 
Created attachment 91827 [details]
Patch
Comment 2 WebKit Review Bot 2011-05-01 10:14:10 PDT 
Attachment 91827 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/win/CursorWin.cpp:85:  Use 0 instead of NULL.  [readability/null] [5]
Source/WebKit/win/WebView.cpp:1053:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 2 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2011-05-01 10:20:39 PDT 
Thanks!!
Comment 4 WebKit Commit Bot 2011-05-01 10:47:43 PDT 
Comment on attachment 91827 [details]
Patch

Clearing flags on attachment: 91827

Committed r85420: <http://trac.webkit.org/changeset/85420>
Comment 5 WebKit Commit Bot 2011-05-01 10:47:48 PDT 
All reviewed patches have been landed.  Closing bug.