Bug 59667 - [Qt]Enable strict OwnPtr
Summary: [Qt]Enable strict OwnPtr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on: 59675
Blocks: 59428
  Show dependency tree / graph
 
Reported: 2011-04-27 18:28 PDT by Adam Barth
Modified: 2011-04-29 14:01 PDT (History)
4 users (show)

See Also:

Attachments
Patch (958 bytes, patch)
2011-04-27 18:28 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2011-04-27 18:57 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (6.56 KB, patch)
2011-04-29 09:47 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-04-27 18:28:12 PDT 
Enable strict OwnPtr for Qt
Comment 1 Adam Barth 2011-04-27 18:28:25 PDT 
Created attachment 91400 [details]
Patch
Comment 2 Adam Barth 2011-04-27 18:28:55 PDT 
This is speculative.
Comment 3 David Levin 2011-04-27 18:29:03 PDT 
Comment on attachment 91400 [details]
Patch

Just trying to improve my r+ stats.
Comment 4 Early Warning System Bot 2011-04-27 18:51:03 PDT 
Attachment 91400 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8514408
Comment 5 Adam Barth 2011-04-27 18:57:41 PDT 
Created attachment 91406 [details]
Patch
Comment 6 Adam Barth 2011-04-27 18:57:55 PDT 
Hum...  The bot only reports one error per run.  This could take a while...
Comment 7 Early Warning System Bot 2011-04-27 19:19:36 PDT 
Attachment 91406 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8519156
Comment 8 Csaba Osztrogonác 2011-04-29 09:47:45 PDT 
Created attachment 91691 [details]
Patch
Comment 9 Tor Arne Vestbø 2011-04-29 10:18:01 PDT 
Comment on attachment 91691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=91691&action=review

> Source/WebCore/platform/graphics/qt/ImageBufferQt.cpp:52
>  {

Y no m_painter(adoptPtr(new QPainter)) ?
Comment 10 Csaba Osztrogonác 2011-04-29 11:54:25 PDT 
Landed in http://trac.webkit.org/changeset/85343
Comment 11 Csaba Osztrogonác 2011-04-29 12:31:03 PDT 
And a buildfix landed in http://trac.webkit.org/changeset/85349
Comment 12 Csaba Osztrogonác 2011-04-29 14:01:53 PDT 
And one more buildfix: http://trac.webkit.org/changeset/85357