Bug 59909 - Remove obsolete LOOSE_OWN_PTR code
Summary: Remove obsolete LOOSE_OWN_PTR code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
: 60670 (view as bug list)
Depends on: 59428
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-01 18:24 PDT by Patrick R. Gansterer
Modified: 2011-06-15 18:17 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2011-05-01 18:25 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Patch (6.45 KB, patch)
2011-06-15 12:38 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (8.86 KB, patch)
2011-06-15 12:43 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-05-01 18:24:31 PDT 
Remove obsolete LOOSE_OWN_PTR code
Comment 1 Patrick R. Gansterer 2011-05-01 18:25:21 PDT 
Created attachment 91868 [details]
Patch
Comment 2 Adam Barth 2011-05-01 18:37:46 PDT 
Comment on attachment 91868 [details]
Patch

This is still used in a couple files that were tricky to fix.  Also, Darin asked that we leave this code around for a bit presumably because some code inside Apple needs to be updated.
Comment 3 Early Warning System Bot 2011-05-01 18:46:07 PDT 
Attachment 91868 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8530490
Comment 4 WebKit Review Bot 2011-05-01 19:48:05 PDT 
Attachment 91868 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8531524
Comment 5 WebKit Review Bot 2011-05-01 21:47:38 PDT 
Attachment 91868 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8531540
Comment 6 WebKit Review Bot 2011-05-01 22:27:54 PDT 
Attachment 91868 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8529521
Comment 7 WebKit Review Bot 2011-05-01 22:49:19 PDT 
Attachment 91868 [details] did not build on mac:
Build output: http://queues.webkit.org/results/8530543
Comment 8 Build Bot 2011-05-01 23:17:27 PDT 
Attachment 91868 [details] did not build on win:
Build output: http://queues.webkit.org/results/8530555
Comment 9 Collabora GTK+ EWS bot 2011-05-01 23:23:51 PDT 
Attachment 91868 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8532106
Comment 10 WebKit Review Bot 2011-05-01 23:33:44 PDT 
Attachment 91868 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8525810
Comment 11 Darin Adler 2011-06-15 12:38:24 PDT 
Created attachment 97345 [details]
Patch
Comment 12 Darin Adler 2011-06-15 12:38:43 PDT 
*** Bug 60670 has been marked as a duplicate of this bug. ***
Comment 13 Darin Adler 2011-06-15 12:40:17 PDT 
Comment on attachment 97345 [details]
Patch

Oops, looks like this will break Chromium, which still has two files depending on LOOSE_OWN_PTR.
Comment 14 Darin Adler 2011-06-15 12:43:45 PDT 
Created attachment 97346 [details]
Patch
Comment 15 Adam Barth 2011-06-15 14:28:39 PDT 
Comment on attachment 97346 [details]
Patch

Yay.  Darin, you're my hero.
Comment 16 Darin Adler 2011-06-15 18:17:49 PDT 
Comment on attachment 97346 [details]
Patch

Clearing flags on attachment: 97346

Committed r88988: <http://trac.webkit.org/changeset/88988>
Comment 17 Darin Adler 2011-06-15 18:17:54 PDT 
All reviewed patches have been landed.  Closing bug.