Bug 60670 – Remove LOOSE_PASS_OWN_ARRAY_PTR

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Template Framework

[Patrick R. Gansterer]

Remove LOOSE_PASS_OWN_ARRAY_PTR

[Patrick R. Gansterer]

Created attachment 93201 [details]
Patch

[Patrick R. Gansterer]

Does Apple have some internal dependencies on OwnArrayPtr?

[Adam Barth]

Comment on attachment 93201 [details]
Patch

I think it's safe to remove this if everything compiles.  If we screw something up internally for Apple, I'm sure someone will tell us and we can revert this patch.

[Mark Rowe (bdash)]

We added this code back in because it is being used.

[Adam Barth]

(In reply to comment #4)
> We added this code back in because it is being used.

Is there a timetable after which we can remove the code?

[Mark Rowe (bdash)]

(In reply to comment #5)
> (In reply to comment #4)
> > We added this code back in because it is being used.
> 
> Is there a timetable after which we can remove the code?

Is there an urgent need to remove it?

[Adam Barth]

> Is there an urgent need to remove it?

Looks like it hasn't been used by WebKit in since <http://trac.webkit.org/changeset/77785>, which was 3 months ago.  I'm happy to wait another 3 months if that's convenient for Apple internally, but I would like to remove the code at some point.

[Mark Rowe (bdash)]

The code can safely be removed when it’s no longer used.  Given the tiny amount of code involved, and its unchanging nature, it seems absurd to try and force the issue.

[Adam Barth]

My concern is that without a deadline we'll never remove the code.  Presumably we'll have the same issue with the other "LOOSE" code for the other smart pointer types.  It seems reasonable to want to not carry this dead code forever.

If three months is not enough, how about six months?

[Mark Rowe (bdash)]

> My concern is that without a deadline we'll never remove the code.

Was I somehow unclear when I stated that this code can be removed when it is unused?

[Darin Adler]

Adam, please cool your jets on this one. This is a very small number of lines of code, and it’s extremely helpful to me and my team at Apple to have this in there for a short while longer.

We *will* remove it when we’re not relying on it any more.

You’re coming on too strong.

You may recall I specifically called this out at the contributors meeting.

There must be more-worthwhile things for us to spend our time on.

I’ll take this bug and I promise to deal with it.

[Patrick R. Gansterer]

@darin: maybe you want to take bug 59909 too

[Adam Barth]

> You’re coming on too strong.

Sorry if I came across too strongly.  That wasn't my intent.

[Darin Adler]

Decided to handle all of these at once in bug 59909.

*** This bug has been marked as a duplicate of bug 59909 ***