Bug 60670 - Remove LOOSE_PASS_OWN_ARRAY_PTR
Summary: Remove LOOSE_PASS_OWN_ARRAY_PTR
Status: RESOLVED DUPLICATE of bug 59909
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-11 15:44 PDT by Patrick R. Gansterer
Modified: 2011-06-15 12:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.54 KB, patch)
2011-05-11 15:50 PDT, Patrick R. Gansterer 		mrowe: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-05-11 15:44:09 PDT 
Remove LOOSE_PASS_OWN_ARRAY_PTR
Comment 1 Patrick R. Gansterer 2011-05-11 15:50:43 PDT 
Created attachment 93201 [details]
Patch
Comment 2 Patrick R. Gansterer 2011-05-11 15:54:52 PDT 
Does Apple have some internal dependencies on OwnArrayPtr?
Comment 3 Adam Barth 2011-05-11 16:17:23 PDT 
Comment on attachment 93201 [details]
Patch

I think it's safe to remove this if everything compiles.  If we screw something up internally for Apple, I'm sure someone will tell us and we can revert this patch.
Comment 4 Mark Rowe (bdash) 2011-05-11 16:57:19 PDT 
We added this code back in because it is being used.
Comment 5 Adam Barth 2011-05-11 16:58:34 PDT 
(In reply to comment #4)
> We added this code back in because it is being used.

Is there a timetable after which we can remove the code?
Comment 6 Mark Rowe (bdash) 2011-05-11 17:02:01 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > We added this code back in because it is being used.
> 
> Is there a timetable after which we can remove the code?

Is there an urgent need to remove it?
Comment 7 Adam Barth 2011-05-11 17:04:48 PDT 
> Is there an urgent need to remove it?

Looks like it hasn't been used by WebKit in since <http://trac.webkit.org/changeset/77785>, which was 3 months ago.  I'm happy to wait another 3 months if that's convenient for Apple internally, but I would like to remove the code at some point.
Comment 8 Mark Rowe (bdash) 2011-05-11 17:09:21 PDT 
The code can safely be removed when it’s no longer used.  Given the tiny amount of code involved, and its unchanging nature, it seems absurd to try and force the issue.
Comment 9 Adam Barth 2011-05-11 17:14:30 PDT 
My concern is that without a deadline we'll never remove the code.  Presumably we'll have the same issue with the other "LOOSE" code for the other smart pointer types.  It seems reasonable to want to not carry this dead code forever.

If three months is not enough, how about six months?
Comment 10 Mark Rowe (bdash) 2011-05-11 17:19:52 PDT 
> My concern is that without a deadline we'll never remove the code.

Was I somehow unclear when I stated that this code can be removed when it is unused?
Comment 11 Darin Adler 2011-05-11 17:27:41 PDT 
Adam, please cool your jets on this one. This is a very small number of lines of code, and it’s extremely helpful to me and my team at Apple to have this in there for a short while longer.

We *will* remove it when we’re not relying on it any more.

You’re coming on too strong.

You may recall I specifically called this out at the contributors meeting.

There must be more-worthwhile things for us to spend our time on.

I’ll take this bug and I promise to deal with it.
Comment 12 Patrick R. Gansterer 2011-05-11 17:30:48 PDT 
@darin: maybe you want to take bug 59909 too
Comment 13 Adam Barth 2011-05-11 17:35:18 PDT 
> You’re coming on too strong.

Sorry if I came across too strongly.  That wasn't my intent.
Comment 14 Darin Adler 2011-06-15 12:38:43 PDT 
Decided to handle all of these at once in bug 59909.

*** This bug has been marked as a duplicate of bug 59909 ***