Bug 50316

Summary: Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: mdelaney7, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 42025, 50322, 50323, 50383, 50440    
Attachments:
Description Flags
Patch xan.lopez: review+

Nikolas Zimmermann
Reported 2010-12-01 02:27:01 PST
Split DECLARE_ANIMATED_PROPERTY_NEW in two macros: DECLARE/DEFINE_ANIMATED_PROPERTY, to avoid having to include SVGNames.h in the headers, that only want to declare the animated properties. Create simple DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH macro pairs, and deploy them everywhere, as first step.
Attachments
Patch (90.57 KB, patch)
2010-12-01 02:29 PST, Nikolas Zimmermann 		xan.lopez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-12-01 02:29:41 PST
Created attachment 75262 [details] Patch Starting to convert SVGLength. The global SVGNames.h will go away, as soon as all types are converted. But it's only a simple mechanical task, it should be done soon....
Xan Lopez
Comment 2 2010-12-01 03:32:44 PST
Comment on attachment 75262 [details] Patch I think this is one good example of a patch where mixing style fixes makes things harder to read :) Looks reasonable to me otherwise. You might want to get rid of the file list in the ChangeLog if you are not going to use it to add inline comments, since it's pretty big.
Nikolas Zimmermann
Comment 3 2010-12-01 04:11:57 PST
(In reply to comment #2) > (From update of attachment 75262 [details]) > I think this is one good example of a patch where mixing style fixes makes things harder to read :) True, I just had to do the changes, to make the style bot happy... :-)
Nikolas Zimmermann
Comment 4 2010-12-01 07:18:38 PST
Landed in r70316.
Note You need to log in before you can comment on or make changes to this bug.