Split DECLARE_ANIMATED_PROPERTY* in DECLARE/DEFINE parts for SVGLength

• Component: SVG
• Status: RESOLVED FIXED

[Nikolas Zimmermann]

Split DECLARE_ANIMATED_PROPERTY_NEW in two macros: DECLARE/DEFINE_ANIMATED_PROPERTY, to avoid having to include SVGNames.h in the headers, that only want to declare the animated properties.
Create simple DECLARE_ANIMATED_LENGTH / DEFINE_ANIMATED_LENGTH macro pairs, and deploy them everywhere, as first step.

[Nikolas Zimmermann]

Created attachment 75262 [details]
Patch

Starting to convert SVGLength. The global SVGNames.h will go away, as soon as all types are converted.
But it's only a simple mechanical task, it should be done soon....

[Xan Lopez]

Comment on attachment 75262 [details]
Patch

I think this is one good example of a patch where mixing style fixes makes things harder to read :)

Looks reasonable to me otherwise. You might want to get rid of the file list in the ChangeLog if you are not going to use it to add inline comments, since it's pretty big.

[Nikolas Zimmermann]

(In reply to comment #2)
> (From update of attachment 75262 [details])
> I think this is one good example of a patch where mixing style fixes makes things harder to read :)

True, I just had to do the changes, to make the style bot happy... :-)

[Nikolas Zimmermann]

Landed in r70316.