Bug 42964

Summary: tables/mozilla/other/slashlogo.html fails after r63994
Product: WebKit Reporter: Marcus Bulach <bulach>
Component: TablesAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED ---    
Severity: Normal CC: andreip, fsamuel, jamesr, victorw
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Actual image
none
Actual text
none
Text diff
none
Patch none

Description Marcus Bulach 2010-07-26 04:41:05 PDT
Created attachment 62558 [details]
Actual image

After http://trac.webkit.org/changeset/63994, 
tables/mozilla/other/slashlogo.html started failing.
Comment 1 Marcus Bulach 2010-07-26 04:41:54 PDT
Created attachment 62559 [details]
Actual text
Comment 2 Marcus Bulach 2010-07-26 04:42:20 PDT
Created attachment 62560 [details]
Text diff
Comment 3 Marcus Bulach 2010-07-26 04:49:50 PDT
Created attachment 62562 [details]
Patch
Comment 4 Andrei Popescu 2010-07-26 04:56:53 PDT
LGTM
Comment 5 Marcus Bulach 2010-07-26 05:04:37 PDT
Committed r64043: <http://trac.webkit.org/changeset/64043>
Comment 6 Marcus Bulach 2010-07-26 05:07:03 PDT
Hi James, Samuel,

I added a temporary expectation for disabling this test, would you mind taking a look and then reverting the expectation?

Thanks!
Marcus
Comment 7 Fady Samuel 2010-07-26 06:02:28 PDT
Odd, this test is not failing on my local build. I'll sync to head and try again to see if I can repro. By the way, my first name is Fady, and my last name is Samuel. :)
Comment 8 Marcus Bulach 2010-07-26 06:15:19 PDT
(In reply to comment #7)
> Odd, this test is not failing on my local build. I'll sync to head and try again to see if I can repro. By the way, my first name is Fady, and my last name is Samuel. :)

Thanks for taking a look Fady! :)
I have it consistently failing on my local linux box, ping me if you need more data.
Comment 9 Fady Samuel 2010-07-26 06:25:33 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > Odd, this test is not failing on my local build. I'll sync to head and try again to see if I can repro. By the way, my first name is Fady, and my last name is Samuel. :)
> 
> Thanks for taking a look Fady! :)
> I have it consistently failing on my local linux box, ping me if you need more data.

I'm seeing a bunch of unexpected PASSES:

Expected to fail, but passed: (23)
  tables/mozilla/bugs/45621.html
  tables/mozilla/bugs/bug137388-2.html
  tables/mozilla/bugs/bug2479-1.html
  tables/mozilla/bugs/bug28341.html
  tables/mozilla/bugs/bug29314.html
  tables/mozilla/bugs/bug2997.html
  tables/mozilla/bugs/bug32205-2.html
  tables/mozilla/bugs/bug3977.html
  tables/mozilla/bugs/bug43854-1.html
  tables/mozilla/bugs/bug650.html
  tables/mozilla/bugs/bug73321.html
  tables/mozilla/bugs/bug96334.html
  tables/mozilla/bugs/bug96343.html
  tables/mozilla/core/captions.html
  tables/mozilla/core/cell_heights.html
  tables/mozilla/marvin/backgr_simple-table-column.html
  tables/mozilla/marvin/backgr_simple-table-row.html
  tables/mozilla/marvin/x_table_bgcolor_rgb.xml
  tables/mozilla/other/nestedTables.html
  tables/mozilla/other/slashlogo.html
  tables/mozilla/other/test3.html
  tables/mozilla/other/wa_table_thtd_rowspan.html
  tables/mozilla/other/wa_table_tr_align.html
Comment 10 Fady Samuel 2010-07-26 07:01:15 PDT
Ok, been able to repro. Looks like I can repro it about once every 10 runs or so. I'm guessing I introduced a subtle bug...maybe touching uninitialized memory in some cases or whatnot causing inconsistent behavior. I'll look into the the issue and get a patch out as soon as I can.
Comment 11 Victor Wang 2010-07-26 12:41:39 PDT
(In reply to comment #10)
> Ok, been able to repro. Looks like I can repro it about once every 10 runs or so. I'm guessing I introduced a subtle bug...maybe touching uninitialized memory in some cases or whatnot causing inconsistent behavior. I'll look into the the issue and get a patch out as soon as I can.

Fady.

tables/mozilla_expected_failures/bugs/bug89315.html also becomes flaky after webkit roll r63992, maybe the same reason?
Comment 12 Fady Samuel 2010-07-27 08:51:53 PDT
The patch I posted for bug 42993 addresses this issue as well:

https://bugs.webkit.org/show_bug.cgi?id=42993