| Summary: | tables/mozilla/other/slashlogo.html fails after r63994 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Marcus Bulach <bulach> | ||||||||||
| Component: | Tables | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED INVALID | ||||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, andreip, fsamuel, jamesr, simon.fraser, victorw, zalan | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Marcus Bulach
2010-07-26 04:41:05 PDT
Created attachment 62559 [details]
Actual text
Created attachment 62560 [details]
Text diff
Created attachment 62562 [details]
Patch
LGTM Committed r64043: <http://trac.webkit.org/changeset/64043> Hi James, Samuel, I added a temporary expectation for disabling this test, would you mind taking a look and then reverting the expectation? Thanks! Marcus Odd, this test is not failing on my local build. I'll sync to head and try again to see if I can repro. By the way, my first name is Fady, and my last name is Samuel. :) (In reply to comment #7) > Odd, this test is not failing on my local build. I'll sync to head and try again to see if I can repro. By the way, my first name is Fady, and my last name is Samuel. :) Thanks for taking a look Fady! :) I have it consistently failing on my local linux box, ping me if you need more data. (In reply to comment #8) > (In reply to comment #7) > > Odd, this test is not failing on my local build. I'll sync to head and try again to see if I can repro. By the way, my first name is Fady, and my last name is Samuel. :) > > Thanks for taking a look Fady! :) > I have it consistently failing on my local linux box, ping me if you need more data. I'm seeing a bunch of unexpected PASSES: Expected to fail, but passed: (23) tables/mozilla/bugs/45621.html tables/mozilla/bugs/bug137388-2.html tables/mozilla/bugs/bug2479-1.html tables/mozilla/bugs/bug28341.html tables/mozilla/bugs/bug29314.html tables/mozilla/bugs/bug2997.html tables/mozilla/bugs/bug32205-2.html tables/mozilla/bugs/bug3977.html tables/mozilla/bugs/bug43854-1.html tables/mozilla/bugs/bug650.html tables/mozilla/bugs/bug73321.html tables/mozilla/bugs/bug96334.html tables/mozilla/bugs/bug96343.html tables/mozilla/core/captions.html tables/mozilla/core/cell_heights.html tables/mozilla/marvin/backgr_simple-table-column.html tables/mozilla/marvin/backgr_simple-table-row.html tables/mozilla/marvin/x_table_bgcolor_rgb.xml tables/mozilla/other/nestedTables.html tables/mozilla/other/slashlogo.html tables/mozilla/other/test3.html tables/mozilla/other/wa_table_thtd_rowspan.html tables/mozilla/other/wa_table_tr_align.html Ok, been able to repro. Looks like I can repro it about once every 10 runs or so. I'm guessing I introduced a subtle bug...maybe touching uninitialized memory in some cases or whatnot causing inconsistent behavior. I'll look into the the issue and get a patch out as soon as I can. (In reply to comment #10) > Ok, been able to repro. Looks like I can repro it about once every 10 runs or so. I'm guessing I introduced a subtle bug...maybe touching uninitialized memory in some cases or whatnot causing inconsistent behavior. I'll look into the the issue and get a patch out as soon as I can. Fady. tables/mozilla_expected_failures/bugs/bug89315.html also becomes flaky after webkit roll r63992, maybe the same reason? The patch I posted for bug 42993 addresses this issue as well: https://bugs.webkit.org/show_bug.cgi?id=42993 It is only marked as 'Pass Slow' on GTK. https://searchfox.org/wubkat/source/LayoutTests/platform/gtk/TestExpectations#1601 But don't have any 'Skip' or 'Failure' today. Do we need to track this? tables/mozilla/other/slashlogo.html ['PASS'] |