Bug 43854 – Web Inspector: remove openInInspectorWindow and evaluateAndStringify from InjectedScript.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 64118 [details]
[PATCH] Proposed change.

[WebKit Review Bot]

Attachment 64118 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/inspector/InspectorController.cpp:50:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/inspector/InspectorController.cpp:1930:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Comment on attachment 64118 [details]
[PATCH] Proposed change.

WebCore/inspector/InspectorController.cpp:1884
 +      newFrame->loader()->setOpener(mainFrame);
We may want to break this link for security reasons(to avoid possibility for the inspected page to open an arbitrary URL by means of the web inspector and have an access to it).

WebCore/inspector/InspectorController.cpp:1925
 +  InjectedScript InspectorController::injectedScriptForId(long id)
It's not used anywhere, please remove.

WebCore/inspector/front-end/InjectedScriptAccess.js: 
 +  InjectedScriptAccess._installHandler("evaluateAndStringify");
Please fix the callers.

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 64118 [details])
> WebCore/inspector/InspectorController.cpp:1884
>  +      newFrame->loader()->setOpener(mainFrame);
> We may want to break this link for security reasons(to avoid possibility for the inspected page to open an arbitrary URL by means of the web inspector and have an access to it).
> 

It is not worse than it used to be + I don't think it is exploitable.

> WebCore/inspector/InspectorController.cpp:1925
>  +  InjectedScript InspectorController::injectedScriptForId(long id)
> It's not used anywhere, please remove.
> 

Done.

> WebCore/inspector/front-end/InjectedScriptAccess.js: 
>  +  InjectedScriptAccess._installHandler("evaluateAndStringify");
> Please fix the callers.


Done.

[Pavel Feldman]

Created attachment 64320 [details]
[PATCH] Proposed change

[Pavel Feldman]

Comment on attachment 64320 [details]
[PATCH] Proposed change

Clearing flags on attachment: 64320

Committed r65314: <http://trac.webkit.org/changeset/65314>

[Pavel Feldman]

All reviewed patches have been landed.  Closing bug.