Summary: | WebKitTestRunner needs a more-complete implementation of eventSender | ||
---|---|---|---|
Product: | WebKit | Reporter: | Maciej Stachowiak <mjs> |
Component: | WebKit2 | Assignee: | Chang Shu <cshu> |
Status: | ASSIGNED --- | ||
Severity: | Normal | CC: | christian.webkit, cmarcelo, cshu, darin, ddkilzer, jbedard, jberlin, kbalazs, laszlo.gombos, mjs, ossy, rniwa, sam, thorton, wenson_hsieh |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | OS X 10.5 | ||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=157179 https://bugs.webkit.org/show_bug.cgi?id=208566 |
||
Bug Depends on: | 64285, 68552, 57515, 57573, 68108, 68556, 69946, 86881, 117070 | ||
Bug Blocks: | 55056, 56484, 76986 |
Description
Maciej Stachowiak
2010-07-13 13:52:28 PDT
My plan is to: 1. implement a coding mechanism for EventSender under WebKit2/WebProcess/InjectedBundle. I have tried to put this under Tools/WebKitTestRunner/InjectedBundle. However, it heavily depends on WebCore and CoreIPC code. 2. Use WKBundlePostMessage to send the EventSenderMessage over to UIProcess/WebContext. 3. When Tools/WebKitTestRunner/TestController receives message, call into WebKit2/WebProcess/InjectedBundle to decode the message and then trigger corresponding functions. Does it make sense? Thanks Have you made any progress on this? I ask because I was about to work on this myself. There is already an eventSender in WebKitTestRunner, but we haven’t hooked any events up yet. (In reply to comment #4) > I ask because I was about to work on this myself. There is already an eventSender in WebKitTestRunner, but we haven’t hooked any events up yet. Yes, I started with the KeyDown function on the Qt platform. https://bugs.webkit.org/show_bug.cgi?id=56485 The patch has been there for quite some time. It will be great if you can take a look. Btw, that patch needs some polish. I also want to get some feedback on the comment#7 of the above bug before I submit the 2nd-round patch. I can also provide an equivalent patch based on Mac. (In reply to comment #5) > The patch has been there for quite some time. It will be great if you can take a look. Btw, that patch needs some polish. I also want to get some feedback on the comment#7 of the above bug before I submit the 2nd-round patch. I’m sorry I never sent you feedback on that patch. I’m not sure what the best next step is. Sam, Maciej, your thoughts? (In reply to comment #7) > (In reply to comment #5) > > The patch has been there for quite some time. It will be great if you can take a look. Btw, that patch needs some polish. I also want to get some feedback on the comment#7 of the above bug before I submit the 2nd-round patch. > > I’m sorry I never sent you feedback on that patch. I’m not sure what the best next step is. > > Sam, Maciej, your thoughts? That's fine. Actually, in my latest patch for bug 57515 (keydown), I created some generalized WK-api for decoding. Thus, I don't have to expose CoreIPC anymore. I think this approach is ok. Hope you guys agree. *** Bug 58059 has been marked as a duplicate of this bug. *** Added another test to the skipped list which uses eventSender.keyDown: http://trac.webkit.org/changeset/83402 (In reply to comment #10) > Added another test to the skipped list which uses eventSender.keyDown: http://trac.webkit.org/changeset/83402 One more test added: http://trac.webkit.org/changeset/84903 *** Bug 61394 has been marked as a duplicate of this bug. *** *** Bug 212582 has been marked as a duplicate of this bug. *** |