Bug 157179 - [GTK] Drag and drop can't be tested with WebKitTestRunner
Summary: [GTK] Drag and drop can't be tested with WebKitTestRunner
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, LayoutTestFailure
: 202898 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-04-29 06:24 PDT by Carlos Garcia Campos
Modified: 2019-10-14 00:42 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-04-29 06:24:39 PDT
The problem is that GTK+ is emitting the drag and drop events, because the drag and drop context is not handling the synthetic events generated by the EventSenderProxy. So, for example, when we generate a GDK_MOTION_NOTIFY by EventSenderProxy::mouseMoveTo(), the GdkDragContext doesn't handle that event and DRAG_MOTION is not called preventing the rest of the drag and drop protocol from working properly. So, in our tests we are never emitting the ondragenter and ondragover. I don't know if we can emulate it somehow, but we currently have several tests in the TestExpectation file pointing to a fixed bug, so we should at least update them to point to this bug.
Comment 1 Carlos Garcia Campos 2016-05-03 02:08:58 PDT
Committed r200366: <http://trac.webkit.org/changeset/200366>
Comment 2 Carlos Garcia Campos 2016-05-03 02:11:25 PDT
webkit-patch closed this, I just updated the test expectations in r200366, re-opening.
Comment 3 Michael Catanzaro 2016-10-16 20:29:26 PDT
Layout test plugins/mouse-events.html, marked against this bug, has been timing out for a while now, first recorded in r191879. Updating expectations accordingly.
Comment 4 Carlos Garcia Campos 2017-02-11 04:19:47 PST
It seems in wayland dnd events are generated, but ends up crashing. Probably because synthesized events generated them, but I don't really know.
Comment 5 Carlos Alberto Lopez Perez 2017-03-07 09:08:12 PST
Expectations updated at: https://trac.webkit.org/changeset/213516/trunk/LayoutTests/platform/gtk-wayland/TestExpectations
Comment 6 Miguel Gomez 2019-06-13 06:00:38 PDT
Adding proper expectations for these tests:

webkit.org/b/157179 editing/pasteboard/4989774.html [ Failure Pass ]
webkit.org/b/157179 editing/pasteboard/paste-line-endings-002.html [ Failure Pass ]
webkit.org/b/157179 editing/pasteboard/paste-list-002.html [ Failure Pass ]
webkit.org/b/157179 editing/pasteboard/paste-list-003.html [ Failure Pass ]
Comment 7 Miguel Gomez 2019-06-13 06:57:26 PDT
(In reply to Miguel Gomez from comment #6)
> Adding proper expectations for these tests:
> 
> webkit.org/b/157179 editing/pasteboard/4989774.html [ Failure Pass ]
> webkit.org/b/157179 editing/pasteboard/paste-line-endings-002.html [ Failure
> Pass ]
> webkit.org/b/157179 editing/pasteboard/paste-list-002.html [ Failure Pass ]
> webkit.org/b/157179 editing/pasteboard/paste-list-003.html [ Failure Pass ]

I've moved these to https://bugs.webkit.org/show_bug.cgi?id=198828 in the expectations, as I think they aren't related to drag&drop
Comment 8 Carlos Garcia Campos 2019-10-14 00:42:24 PDT
*** Bug 202898 has been marked as a duplicate of this bug. ***