Bug 57573 – Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Darin Adler]

Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner

[Darin Adler]

Created attachment 87783 [details]
Patch

[Sam Weinig]

Comment on attachment 87783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87783&action=review

Very nice!

> Tools/WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:32
> +        void mouseDown(in int buttonNumber, in object modifierArray);
> +        void mouseUp(in int buttonNumber, in object modifierArray);
> +        void mouseMoveTo(in int x, in int y);
> +        void leapForward(in int milliseconds);

I think we traditionally use long to mean int in IDL.

[Build Bot]

Attachment 87783 [details] did not build on win:
Build output: http://queues.webkit.org/results/8315260

[Darin Adler]

Committed r82625: <http://trac.webkit.org/changeset/82625>

[Chang Shu]

Darin, do you need the help on the similar changes to key events?

[Darin Adler]

(In reply to comment #5)
> Darin, do you need the help on the similar changes to key events?

One word answer: Yes.

I think it’s a good, straightforward step to add key events.

I also want to cut down the Skipped list because I think there are even more mouse-related eventSender tests that are passing with the final version of the patch I landed. But I think that’s platform-specific work because I don’t think we share a WebKit2 skipped list between platforms.

The full “need help” question is a trickier one. I’d love it if you did the work for key events before I got around to it, and I’m not sure when I will next have time for this.

But if do work on it, please cc me on a bug and make comments in bugs.webkit.org as you make progress, maybe even post work in progress when you pause. If I do get time to work on this I might want to pick up your work and finish it if you haven’t already posted a patch for review.

[Chang Shu]

(In reply to comment #6)
> (In reply to comment #5)
> > Darin, do you need the help on the similar changes to key events?
> 
> One word answer: Yes.
> 
> I think it’s a good, straightforward step to add key events.
> 
> I also want to cut down the Skipped list because I think there are even more mouse-related eventSender tests that are passing with the final version of the patch I landed. But I think that’s platform-specific work because I don’t think we share a WebKit2 skipped list between platforms.
> 
> The full “need help” question is a trickier one. I’d love it if you did the work for key events before I got around to it, and I’m not sure when I will next have time for this.
> 
> But if do work on it, please cc me on a bug and make comments in bugs.webkit.org as you make progress, maybe even post work in progress when you pause. If I do get time to work on this I might want to pick up your work and finish it if you haven’t already posted a patch for review.

Thanks, Darin. I will only work on it when you are busy on something else. I would also appreciate it if you could help me push forward the cross-process approach. :)