Bug 39995

Summary:	[Qt] Web Notification support
Product:	WebKit	Reporter:	Yael <yael>
Component:	WebKit Qt	Assignee:	Yael <yael>
Status:	RESOLVED FIXED
Severity:	Enhancement	CC:	ademar, christian.webkit, cristiano.di-flora, hausmann, laszlo.gombos, maheshk, ossy, suresh.voruganti
Priority:	P2	Keywords:	Qt, QtTriaged
Version:	528+ (Nightly build)
Hardware:	PC
OS:	All
Bug Depends on:	39998, 40003, 40004, 40005, 40078, 40127, 40396, 40571, 41413, 44836
Bug Blocks:

Description Yael 2010-06-01 07:29:14 PDT

Web Notification support in QtWebkit is still lacking. This is a meta bug for all the changes I am planning to do.
These changes include:
1. Fix the association between Notification object and JSNotification objects. JSNotification objects are not ref'ed properly and are garbage collected shortly after they were created.
2. Make NotificatioPresenter a singleton. A notification object can outlive the page that created it, and the current design does not allow for that. 
3. Add support for loading icons for the notifications
4. Add support for the platform plugin to override the default behavior.

Things that I did not implement yet:
5. Add support for web workers based notifications.
6. Add support for downloading the markup for HTML based notifications.

Comment 1 Suresh Voruganti 2010-08-25 08:44:29 PDT

Are we expecting any more notification implementation or have finished all implementation tasks?

Can we close this bug? this is blocking Bug 39121 Master bug for QtWebkit 2.1

Comment 2 Yael 2010-08-25 14:44:52 PDT

A few things might still be needed for notifications:
1. The spec is still early draft, and changes to it may impact the implementation in QtWebKit.
2. I was asked to hook up Notifications with the Universal Indicator. This will require changes to the PlatformPlugin interface. 
3. NotificationPresenter in Chromium is quite different than in QtWebKit, and someone asked me to help consolidate the implementations.

Comment 3 Yael 2010-09-13 05:33:00 PDT

#2 was committed in bug 44836. #1 and #3 are long term goals, so I think after bug 44836 is cherry-picked, we should close this bug.

Comment 4 Ademar Reis 2010-09-13 06:21:39 PDT

(In reply to comment #3)
> #2 was committed in bug 44836. #1 and #3 are long term goals, so I think after bug 44836 is cherry-picked, we should close this bug.

If all tasks have been done, please go ahead and close it. Patches are cherry-picked when they (and all dependencies) are closed+fixed and block Bug 39121.

Comment 5 Yael 2010-09-13 06:52:50 PDT

All tasks have been done, closing the bug.

Comment 6 Ademar Reis 2010-09-13 07:45:01 PDT

All changes have been integrated into qtwebkit-2.1, removing Bug 39121 from the blockers list. Thanks.