Bug 40127 - [Qt] Don't send notifications event after the page was navigated away
Summary: [Qt] Don't send notifications event after the page was navigated away
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 39995
  Show dependency treegraph
 
Reported: 2010-06-03 09:41 PDT by Yael
Modified: 2010-08-03 08:33 PDT (History)
1 user (show)

See Also:


Attachments
Patch. (1.92 KB, patch)
2010-06-03 09:47 PDT, Yael
laszlo.gombos: review+
laszlo.gombos: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-06-03 09:41:42 PDT
Notification objects can outlive the page they are in.
If the ScriptExecutionContext that created the notification was destroyed, don't invoke "display" or "close" events on the notification object. When running inside DRT, also don't log after the ScriptExecutionContext was destroyed.

I actually don't understand why this is not causing failures on the build bot.
Comment 1 Yael 2010-06-03 09:47:15 PDT
Created attachment 57783 [details]
Patch.
Comment 2 Laszlo Gombos 2010-06-03 10:12:08 PDT
Comment on attachment 57783 [details]
Patch.

Looks good to me. r+.
Comment 3 Yael 2010-06-03 10:36:10 PDT
Committed r60630: <http://trac.webkit.org/changeset/60630>
Comment 4 Simon Hausmann 2010-08-03 08:33:18 PDT
Revision r60630 cherry-picked into qtwebkit-2.1 with commit 7c263035b4010a8c7cf057eb7d2ba0fdd336929d