Bug 40396 - Support for loading notification icons
Summary: Support for loading notification icons
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Enhancement
Assignee: Nobody
Depends on:
Blocks: 39995 40004
  Show dependency treegraph
Reported: 2010-06-09 17:49 PDT by Yael
Modified: 2010-08-03 08:33 PDT (History)
5 users (show)

See Also:

Patch. (24.89 KB, patch)
2010-06-09 18:11 PDT, Yael
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yael 2010-06-09 17:49:36 PDT
As suggested in https://bugs.webkit.org/show_bug.cgi?id=40004, icon loading should be done in cross platform code.
This is the cross platform part, and https://bugs.webkit.org/show_bug.cgi?id=40004 would take care of the Qt specific code.
A patch is coming soon.
Comment 1 Yael 2010-06-09 18:11:15 PDT
Created attachment 58317 [details]

Make notification objects download the icon needed for displaying the notification before calling the NotificationPresenter to display the notification.

An error during the download would cause the notification to be displayed without an icon.

If a notification is in the process of download, and a new notification is created with the same ReplaceId, the download is not cancelled immediately and the notification is removed only after the download is complete.
Comment 2 Kenneth Rohde Christiansen 2010-06-10 08:03:50 PDT
Comment on attachment 58317 [details]

Looks good, r=me
Comment 3 WebKit Commit Bot 2010-06-10 09:32:20 PDT
Comment on attachment 58317 [details]

Clearing flags on attachment: 58317

Committed r60960: <http://trac.webkit.org/changeset/60960>
Comment 4 WebKit Commit Bot 2010-06-10 09:32:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2010-08-03 08:33:58 PDT
Revision r60960 cherry-picked into qtwebkit-2.1 with commit 5765325aee8a79e7dedcfa4aa2a984bfb162c63d