[Qt] Review all new API in Qt 4.6

• Component: WebKit Qt
• Status: RESOLVED FIXED

[Simon Hausmann]

Most of the new API has been reviewed already, but what's missing includes:

2. QWebFrame::requestedUrl() and QwebFrame::baseUrl()

3. Layout and rendering

We've added a few methods that relate to layout and rendering. These are:

        QWebFrame::clipRenderToViewPort()

        QWebFrame::scrollBarGeometry()
        QWebFrame::contentSizeChanged()

        QWebPage::fixedContentSize()

        QWebView::renderHints()

We need to go though these and consider them together + revisit API.

4. QWebFrame::loadStarted() and QWebFrame::loadFinished()

5. Saving and restoring of QWebHistory

6. QWebKitVersion

7. QWebPluginDatabase

Needs review, also in the context of not having anything to do with 
QWebPluginFactory, ie it's only NPAPI.

8. QWebSecurityOrigin

        QWebSecurityOrigin::add/remove/LocalScheme()
        QWebSecurityOrigin::whitelistAccesFromOrigin()

9. Storage

        New settings in QWebSettings
        Setting of paths        
        Enabling all persistent storage

We need to revisit this and make sure the naming and the API is still 
consistent.

10. Misc added methods

        QWebPage::frameAt()
        QWebFrame::focus()
        QWebPage::shouldInterupJavaScript()
        QWebView::guessUrlFromString()
        QWebSettings::defaltTextEncoding()
        QWebSettings::clearMemoryCached();

11. QWebGraphicsItem

[Simon Hausmann]

We had a quick round of API review with Matthias here at the DevDays and came up with the following suggestions for changes:

* QWebFrame::clipContentsToViewport:

    1) Remove the property
    2) Deprecate QWebFrame::render()
    3) Introduce QWebFrame::paint(QWebFrame::PaintOptions opts = QWebFrame::AllElements), so that one can for eaxmple call

    frame->paint(QWebFrame::Contents);
    frame->paint(QWebFrame::Contents | QWebFrame::ScrollBars);



* QWebFrame::scrollBarGeometry(): good name, keep it

* QWebPage::fixedContentsSize property:

    1) Rename to preferredContentsSize

[Kenneth Rohde Christiansen]

Created attachment 41320 [details]
Rename the fixedContentsSize property

[Simon Hausmann]

Comment on attachment 41320 [details]
Rename the fixedContentsSize property

Thanks! Please fix the spelling of my first name in the ChangeLog when landing though ;-)

[WebKit Commit Bot]

Comment on attachment 41320 [details]
Rename the fixedContentsSize property

Clearing flags on attachment: 41320

Committed r49766: <http://trac.webkit.org/changeset/49766>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Tor Arne Vestbø]

Closed by bot, but this is a tracker-bug

[Kenneth Rohde Christiansen]

Created attachment 41443 [details]
First part of the clipContentsToViewport fix (introduce paint method, deprecate render)

[Kenneth Rohde Christiansen]

Follow up patch will remove the clipContentsToViewport property

[Eric Seidel (no email)]

Please open a new bug for new fixes.  If you want to use tracker bugs, you should open bugs for all the individual fixes and marked them blocked on this one.  I think this bug should be closed and the patch moved to a new bug.

[Tor Arne Vestbø]

I agree with Eric, we should have individual blocker-bugs for each patch.

But do we really need to delete this bug? Can't we obsolete/remove the patches and just keep on using it to track the API reviews?

[Tor Arne Vestbø]

Some comments after a small session we had in Oslo. The only API left now should be QGraphicsWebView.

1. QWebFrame::loadStarted() and QWebFrame::loadFinished()

Do we need these? It's duplicating the problem of the 'ok' argument.

2. QWebKitVersion - Who's going to use this? Are we exposing a version that has no real use?

3. QWebPluginDatabase

Propose to make this private. See bug 30775 

4. QWebSecurityOrigin::add/remove/LocalScheme()

Rename to register*?

5. QWebSecurityOrigin::whitelistAccesFromOrigin() ++

Rename to q_drt (they were added for DRT)

6. Misc

QWebPage::shouldInterupJavaScript() - did we decide to remove this?

QWebSettings::defaltTextEncoding() - QTextCodec?

QWebView::guessUrlFromString()- Remove from WebKit, lives in QUrl now

QWebSettings::setPrintingMinimumShrinkFactor etc

4.6 or 4.7?

[Antonio Gomes]

Tor I'd like to request discussion for https://bugs.webkit.org/show_bug.cgi?id=30771 if possible.

I sent an email to webkit-qt ML ealier today titled "qweb{page,view} and qgraphicswebview createWindow method."

[Kenneth Rohde Christiansen]

(In reply to comment #11)
> Some comments after a small session we had in Oslo. The only API left now
> should be QGraphicsWebView.
> 
> 1. QWebFrame::loadStarted() and QWebFrame::loadFinished()
> 
> Do we need these? It's duplicating the problem of the 'ok' argument.

I think Yael could answer that.

> 2. QWebKitVersion - Who's going to use this? Are we exposing a version that has
> no real use?

Useful for changing the user agent, you want to set the right webkit version. Also useful for browsers.

> Rename to q_drt (they were added for DRT)

In that case I agree.

> 6. Misc
> 
> QWebPage::shouldInterupJavaScript() - did we decide to remove this?

No we did not, but at least there should be a setting to set the timeout.

> QWebView::guessUrlFromString()- Remove from WebKit, lives in QUrl now

It does? since when? Thiago was opposed to that.

[Kenneth Rohde Christiansen]

5. QWebSecurityOrigin::whitelistAccesFromOrigin() ++

Rename to q_drt (they were added for DRT)

DONE. Landed in 50166.

[Kenneth Rohde Christiansen]

> > QWebView::guessUrlFromString()- Remove from WebKit, lives in QUrl now
> 
> It does? since when? Thiago was opposed to that.

OK, it was added, but due to license problems it will be removed from Qt by Thiago and readded by Benjamin (icefox). When this has been done I will remove the method. This should happen early tomorrow morning.

[Yael]

(In reply to comment #13)
> (In reply to comment #11)
> > Some comments after a small session we had in Oslo. The only API left now
> > should be QGraphicsWebView.
> > 
> > 1. QWebFrame::loadStarted() and QWebFrame::loadFinished()
> > 
> > Do we need these? It's duplicating the problem of the 'ok' argument.
> 
> I think Yael could answer that.
> 

Looking at svn logs, I think Simon added these signals for DRT tests, These are not the signals that I have added.

[Kenneth Rohde Christiansen]

(In reply to comment #16)
> (In reply to comment #13)
> > (In reply to comment #11)
> > > Some comments after a small session we had in Oslo. The only API left now
> > > should be QGraphicsWebView.
> > > 
> > > 1. QWebFrame::loadStarted() and QWebFrame::loadFinished()
> > > 
> > > Do we need these? It's duplicating the problem of the 'ok' argument.
> > 
> > I think Yael could answer that.
> > 
> 
> Looking at svn logs, I think Simon added these signals for DRT tests, These are
> not the signals that I have added.

Rename to q_drt (they were added for DRT) then.

[Simon Hausmann]

Closing this bug as all the API has been reviewed and fixed. We're past the deadline of API changes for Qt 4.6 now.