Bug 31249 - [Qt] Remove the sessionStorage setting (per Page)
Summary: [Qt] Remove the sessionStorage setting (per Page)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 29843
  Show dependency treegraph
 
Reported: 2009-11-08 19:21 PST by Laszlo Gombos
Modified: 2009-11-09 11:04 PST (History)
3 users (show)

See Also:


Attachments
remove sessionStorage setting API (4.15 KB, patch)
2009-11-08 19:47 PST, Laszlo Gombos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2009-11-08 19:21:02 PST
This setting does not quite work as a per Page setting (can not turn it off once it has been turned on). The setting does not control persistent data - I do not believe QtWebKit had a strong use-case for this.

Note that this setting API is now in QtWebKit 4.6 production branch - so this patch can only be landed on the trunk if there is a commitment to cherry-pick this change to Qt 4.6 final - I think there is still time.

This is a response to some discussion with Jeremy Orlow on #qtwebkit. Jeremy had a patch related to sessionStorage setting - if the setting will be removed from the Qt API Jeremy's patch should be re-landed as well - see http://trac.webkit.org/changeset/50569.
Comment 1 Laszlo Gombos 2009-11-08 19:47:00 PST
Created attachment 42728 [details]
remove sessionStorage setting API
Comment 2 Kenneth Rohde Christiansen 2009-11-09 05:09:09 PST
If it is not right, we should remove it for now. But one other thing. Session storage is per page group, and according to the spec, if you create a tab or new window from a page group (like open a "next" link in a wizard in another tab) it should clone the session storage.

I wonder if we need a class for dealing with these issues.

Does local storage suffer from any of these issues?
Comment 3 Kenneth Rohde Christiansen 2009-11-09 05:11:13 PST
One question. Is it turned on by default? I at least think we should do that.
Comment 4 Laszlo Gombos 2009-11-09 07:09:36 PST
Comment on attachment 42728 [details]
remove sessionStorage setting API

missing change in qwebsettings.h.
Comment 5 Laszlo Gombos 2009-11-09 11:04:40 PST
Landed as r50659 -  http://trac.webkit.org/changeset/50659.