Bug 30530 - Replace QWebFrame::clipContentsToViewport with better API
Summary: Replace QWebFrame::clipContentsToViewport with better API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 29843
  Show dependency treegraph
 
Reported: 2009-10-19 13:37 PDT by Kenneth Rohde Christiansen
Modified: 2009-10-21 10:40 PDT (History)
2 users (show)

See Also:


Attachments
First part of the clipContentsToViewport fix (introduce paint method, deprecate render) (6.32 KB, patch)
2009-10-19 13:37 PDT, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff
Second version incorporating feedback from IRC (6.45 KB, patch)
2009-10-19 14:42 PDT, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2009-10-19 13:37:40 PDT
Created attachment 41444 [details]
 First part of the clipContentsToViewport fix (introduce paint method, deprecate render) 

We had a quick round of API review with Matthias here at the DevDays and came
up with the following suggestions for changes:

* QWebFrame::clipContentsToViewport:

    1) Remove the property
    2) Deprecate QWebFrame::render()
    3) Introduce QWebFrame::paint(QWebFrame::PaintOptions opts =
QWebFrame::AllElements), so that one can for eaxmple call

    frame->paint(QWebFrame::Contents);
    frame->paint(QWebFrame::Contents | QWebFrame::ScrollBars);
Comment 1 Kenneth Rohde Christiansen 2009-10-19 13:40:04 PDT
Follow up patch will remove the clipContentsToViewport property
Comment 2 Tor Arne Vestbø 2009-10-19 14:05:27 PDT
Comment on attachment 41444 [details]
 First part of the clipContentsToViewport fix (introduce paint method, deprecate render) 

Let's discuss this further before landing
Comment 3 Kenneth Rohde Christiansen 2009-10-19 14:42:36 PDT
Created attachment 41454 [details]
Second version incorporating feedback from IRC
Comment 4 Richard Moore 2009-10-19 15:46:28 PDT
Might be worth considering making the numbers for the enum a bit bigger so that if you later want to add intermediate layers they can still have an id that reflects the stacking order. eg. 0x10, 0x20 etc. instead of 0x01, 0x02.
Comment 5 Kenneth Rohde Christiansen 2009-10-20 13:16:51 PDT
Landed in 49850
Comment 6 Eric Seidel (no email) 2009-10-21 10:40:02 PDT
Comment on attachment 41454 [details]
Second version incorporating feedback from IRC

Supposedly this patch was landed, so removing r?.