RESOLVED INVALID Bug 30775
[Qt] QWebPluginInfo::isNull() should be QWebPluginInfo::isValid()? 
https://bugs.webkit.org/show_bug.cgi?id=30775
Summary [Qt] QWebPluginInfo::isNull() should be QWebPluginInfo::isValid()?
Benjamin Poulain
Reported 2009-10-26 07:54:33 PDT
QWebPluginInfo::isNull() return true if the QWebPluginInfo has been constructed with the default constructor. There is no way to know if a QWebPluginInfo is valid after QWebPluginDatabase::refresh(). QWebPluginInfo::isNull() could be changed in QWebPluginInfo::isValid() and be used for the default constructor and for plugins that have become invalid.
Attachments
Patch (11.70 KB, patch)
2009-11-03 07:37 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Patch (12.34 KB, patch)
2009-11-03 07:46 PST, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tor Arne Vestbø
Comment 1 2009-10-27 06:44:50 PDT
I propose we make this class private in 4.6, it's not ready for prime time.
Kenneth Rohde Christiansen
Comment 2 2009-10-27 07:12:46 PDT
What are the primary concerns?
Tor Arne Vestbø
Comment 3 2009-10-27 07:33:17 PDT
It's a pretty thin wrapper around PluginDatabase/PluginPackage, ie. we're exposing quite a few internals. This results in tricky stuff like what happens if you refresh plugins but have a QWebPluginInfo that points to one of the plugins that were removed? Now it suddenly has a dangling pointer, etc. Basically I'm worried that not all use-cases have not been thought trough (typical for API around already existing functionality), and we end up exposing bugs like this. Add to that that this is really QWeb_Netscape_PluginDatabase, ie has nothing to do with the QWebFactoryPlugins. I tried to proxy this in, but it was a bit hairy.
Kenneth Rohde Christiansen
Comment 4 2009-10-27 07:46:26 PDT
OK I agree, it would be totally acceptable to make this a private API for 4.6. I can have a look at that if you'ld like
Kenneth Rohde Christiansen
Comment 5 2009-10-27 11:40:24 PDT
Laszlo what is your comments on this? What are your requirements for such an API, and when do you need it?
Simon Hausmann
Comment 6 2009-11-03 05:53:34 PST
Jakub, we have concerns regarding the API and given our current release pressure we'd like to delay this API. AFAICS Arora is not using these classes yet. Would you mind if we hold this off for a little while longer?
Simon Hausmann
Comment 7 2009-11-03 07:37:32 PST
Created attachment 42380 [details] Patch
Simon Hausmann
Comment 8 2009-11-03 07:46:14 PST
Created attachment 42382 [details] Patch
Simon Hausmann
Comment 9 2009-11-03 07:55:39 PST
Committed r50456: <http://trac.webkit.org/changeset/50456>
Simon Hausmann
Comment 10 2009-11-03 07:56:56 PST
Re-opening and removing dependency on Qt 4.6 API blocker. Technically this bug is still open, but with the committed patch it's not public API at the moment.
Simon Hausmann
Comment 11 2009-11-03 07:57:57 PST
Comment on attachment 42382 [details] Patch Clearning review after landing.
Jocelyn Turcotte
Comment 12 2014-02-03 03:15:52 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.