Summary: | [GTK][a11y] Web process crashes in some sites having SVG images | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aboxhall, andresg_22, aperez, apinheiro, bugs-noreply, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=234563 https://bugs.webkit.org/show_bug.cgi?id=233804 |
||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 230253, 234740 | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2021-12-28 23:37:09 PST
Created attachment 448066 [details]
Patch
Comment on attachment 448066 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=448066&action=review > Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp:35 > +static AccessibilityAtspi* s_currentAtspi; This smells like we may want to use “NeverDestroyed<AccessibilityAtspi>“ and provide instead a “::singleton()“ method. As far as I find from the code, only the WebProcess will have an instance (and only one) of this, which gets created in “WebProcess::platformInitializeWebProcess()”. Then we could ditch the “WebProcess::m_accessibility” member and the “WebProcess::accessibilityAtspi()“ accessor — then “WebPageGtk.cpp“ can use “AccessibilityAtspi::singleton()”, and that seems the only place where the accessor is ever used. Of course we would still something like an “AccessibilityAtspi::initialize(const String& busAddress)” static method to configure the single instance from “::platformInitializeWebProcess()”. Thoughts? Created attachment 448835 [details]
Patch
Comment on attachment 448835 [details]
Patch
Thanks for the updated patch! I think it looks clearer now and I like
it that now the fact that AccessibilityAtspi is a single instance is
explicitly stated in the code :)
Committed r287876 (245920@trunk): <https://commits.webkit.org/245920@trunk> |