Bug 213979

Summary: REGRESSION(r263953): Broke internal build
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED INVALID    
Severity: Normal CC: darin, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 213980    
Bug Blocks: 212542, 213976, 233304    
Attachments:
Description Flags
REVERT of r263953 none

Yusuke Suzuki
Reported 2020-07-05 17:45:02 PDT
https://trac.webkit.org/changeset/263953 broke the build: Broke internal build This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of r263953 (101.19 KB, patch)
2020-07-05 17:45 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2020-07-05 17:45:12 PDT
Created attachment 403567 [details] REVERT of r263953 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
EWS
Comment 2 2020-07-05 17:46:22 PDT
Committed r263960: <https://trac.webkit.org/changeset/263960> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403567 [details].
Radar WebKit Bug Importer
Comment 3 2020-07-05 17:47:17 PDT
<rdar://problem/65113568>
Yusuke Suzuki
Comment 4 2020-07-05 17:58:18 PDT
Re-opened since this is blocked by bug 213980
Alexey Proskuryakov
Comment 5 2020-07-05 17:59:11 PDT
Re-landing these revisions, because together, they don't break the build somehow.
Note You need to log in before you can comment on or make changes to this bug.