Bug 212542

Summary: [Cocoa] Move almost all features from FeatureDefines.xcconfig to PlatformEnableCocoa.h
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, andersca, benjamin, cdumez, cmarcelo, ddkilzer, ews-watchlist, keith_miller, krollin, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=212541
https://bugs.webkit.org/show_bug.cgi?id=212587
Bug Depends on: 212420, 213962, 213964, 213979    
Bug Blocks: 213949    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch sam: review+

Darin Adler
Reported 2020-05-29 13:56:36 PDT
Move almost all features from FeatureDefines.xcconfig to PlatformEnableCocoa.h
Attachments
Patch (93.01 KB, patch)
2020-05-29 13:58 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (91.71 KB, patch)
2020-05-29 18:18 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (63.03 KB, patch)
2020-07-04 19:02 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (65.73 KB, patch)
2020-07-04 19:45 PDT, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-05-29 13:58:21 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2020-05-29 18:18:52 PDT Comment hidden (obsolete)
Darin Adler
Comment 3 2020-07-04 19:02:04 PDT Comment hidden (obsolete)
Darin Adler
Comment 4 2020-07-04 19:05:08 PDT
I think there will be more cleanup possible after this; seems we should remove the files entirely. The EXPERIMENTAL_FEATURES switching is specific to the WebKit framework, and doesn’t need to be done in all the other projects.
Darin Adler
Comment 5 2020-07-04 19:45:44 PDT
Created attachment 403543 [details] Patch
Darin Adler
Comment 6 2020-07-05 12:32:02 PDT
Committed r263953: <https://trac.webkit.org/changeset/263953>
Radar WebKit Bug Importer
Comment 7 2020-07-05 12:33:20 PDT
<rdar://problem/65109960>
Yusuke Suzuki
Comment 8 2020-07-05 17:45:04 PDT
Re-opened since this is blocked by bug 213979
Alexey Proskuryakov
Comment 9 2020-07-05 17:59:26 PDT
Re-landing via bug 213980.
Note You need to log in before you can comment on or make changes to this bug.