Summary: | [Cocoa] Move almost all features from FeatureDefines.xcconfig to PlatformEnableCocoa.h | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||||
Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | aestes, andersca, benjamin, cdumez, cmarcelo, ddkilzer, ews-watchlist, keith_miller, krollin, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer, ysuzuki | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=212541 https://bugs.webkit.org/show_bug.cgi?id=212587 |
||||||||||||
Bug Depends on: | 212420, 213962, 213964, 213979 | ||||||||||||
Bug Blocks: | 213949 | ||||||||||||
Attachments: |
|
Description
Darin Adler
2020-05-29 13:56:36 PDT
Created attachment 400611 [details]
Patch
Created attachment 400644 [details]
Patch
Created attachment 403542 [details]
Patch
I think there will be more cleanup possible after this; seems we should remove the files entirely. The EXPERIMENTAL_FEATURES switching is specific to the WebKit framework, and doesn’t need to be done in all the other projects. Created attachment 403543 [details]
Patch
Committed r263953: <https://trac.webkit.org/changeset/263953> Re-opened since this is blocked by bug 213979 Re-landing via bug 213980. |