RESOLVED WONTFIX212587
[Cocoa] Bug 212420 breaks XCBuild 
https://bugs.webkit.org/show_bug.cgi?id=212587
Summary [Cocoa] Bug 212420 breaks XCBuild
Keith Rollin
Reported 2020-05-31 23:17:08 PDT
Bug 212420 breaks XCBuild. The problem is that the .xcfilelist for the generated unified sources is removed. This file is used not only to determine dependencies (something that was addressed by the addition of the UnifiedSourceBundlesTimeStamp.txt file), but also to notify XCBuild how and when generated files are created. Without this file, XCBuild doesn't know where the UnifiedSource*.* files are coming from and it fails when it tries to compile them.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-05-31 23:17:20 PDT
<rdar://problem/63818686>
Darin Adler
Comment 2 2020-06-01 07:17:04 PDT
How does this work for all the other derived sources? We should be able to fix this by making it the same as the rest.
Darin Adler
Comment 3 2020-06-01 08:08:39 PDT
Keith, I’m happy to fix this so that the file list contains the list of unified source files. If you can help me figure out the strategy, I’ll do it.
Darin Adler
Comment 4 2020-06-01 08:19:59 PDT
I’m having trouble getting used to the overall strategy here. Inelegant always having to regenerate the file lists in a separate pass every time we build. Seems like a recipe for slow builds to process all the dependencies twice, once to build and once to check/rebuild xcfilelist files. But given the strategy, seems like somehow I am going to have to get --generate-xcfilelists and --output-xcfilelist-path passed in to the generate-unified-sources.sh script so it can build the list of files. Then either communicate this directly to the Python generator class, or just add these files all as dependencies in make so that it will show up in the output of "make -d". Too bad I’ve never programmed in Ruby or Python before!
Darin Adler
Comment 5 2020-06-01 08:21:36 PDT
It would be fine to revert r262310 until we figure out a way to deal with this.
Darin Adler
Comment 6 2020-06-01 13:03:17 PDT
Keith, do you have a preference for what we do next?
Darin Adler
Comment 7 2020-06-01 13:03:49 PDT
I guess you assigned this bug to me, so you want me to fix it, but do you have a preferred approach?
Keith Rollin
Comment 8 2020-06-01 15:32:10 PDT
This is low priority for now, until we determine an approach.
Keith Rollin
Comment 9 2020-08-05 15:02:11 PDT
Bug 212420 has been addressed with a different approach. The larger issue -- that of having a separate pass to ensure that the .xcfilelist files are up-to-date -- is covered in Radar 48250806. Therefore, nothing more to do here.
Note You need to log in before you can comment on or make changes to this bug.