Bug 205335

Summary: [GTK][WPE] Enable WebGL by default
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205334
Attachments:
Description Flags
Patch aperez: review+, aperez: commit-queue-

Michael Catanzaro
Reported 2019-12-17 06:30:13 PST
I noticed WebGL is still disabled by default. This is weird since it's been mature for a long time now. I would flip the default similarly to how we enabled MSE in bug #190243. Note: bug #69706 attempted to do this, but failed because there's also a runtime setting.
Attachments
Patch (2.33 KB, patch)
2020-01-21 01:10 PST, Carlos Garcia Campos 		aperez: review+
aperez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-01-21 01:10:59 PST
Created attachment 388286 [details] Patch
EWS Watchlist
Comment 2 2020-01-21 01:12:07 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Adrian Perez
Comment 3 2020-01-21 02:00:09 PST
Comment on attachment 388286 [details] Patch Patch LGTM, but let's fix the indentation issue reported by the style checker while at it before commiting :)
Adrian Perez
Comment 4 2020-01-21 02:00:55 PST
Oh, and for the record I agree that it seems like a very good idea to have WebGL enabled by default.
Carlos Garcia Campos
Comment 5 2020-01-21 03:28:18 PST
Committed r254848: <https://trac.webkit.org/changeset/254848>
Note You need to log in before you can comment on or make changes to this bug.