Bug 203949

Summary: REGRESSION: r252121 introduced timeout in webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: New BugsAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=203763
https://bugs.webkit.org/show_bug.cgi?id=203908
https://bugs.webkit.org/show_bug.cgi?id=203984
https://bugs.webkit.org/show_bug.cgi?id=204029
Attachments:
Description Flags
Patch none

Aakash Jain
Reported 2019-11-07 05:43:31 PST
The changes in https://trac.webkit.org/changeset/252121/webkit is causing the test webgl/1.0.3/conformance/glsl/misc/shader-with-non-reserved-words.html to timeout consistently. Its expectation for mac/gtk/wpe is slow, e.g.: https://trac.webkit.org/browser/webkit/trunk/LayoutTests/platform/mac/TestExpectations#L401 However it is consistently timing out on all platforms: https://results.webkit.org/?suite=layout-tests&test=webgl%2F1.0.3%2Fconformance%2Fglsl%2Fmisc%2Fshader-with-non-reserved-words.html Results: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r252180%20(6765)/results.html
Attachments
Patch (4.52 KB, patch)
2019-11-07 13:23 PST, Justin Fan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-11-07 05:44:56 PST
This is also slowing mac mac-debug-wk1 ews. e.g.: https://ews-build.webkit.org/#/builders/17/builds/5961
Radar WebKit Bug Importer
Comment 2 2019-11-07 05:45:00 PST
<rdar://problem/56979888>
Justin Fan
Comment 3 2019-11-07 13:23:15 PST
Created attachment 383068 [details] Patch
Justin Fan
Comment 4 2019-11-07 13:34:21 PST
Comment on attachment 383068 [details] Patch Clearing flags on attachment: 383068 Committed r252204: <https://trac.webkit.org/changeset/252204>
Justin Fan
Comment 5 2019-11-07 13:34:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.