Summary: | Web Inspector: default to focusing the console prompt if no other content is focused after opening Web Inspector | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bburg, commit-queue, eric.carlson, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 203744, 203932, 203939 | ||||||||||||
Attachments: |
|
Description
Devin Rousso
2019-11-01 09:54:39 PDT
Created attachment 382590 [details]
Patch
Comment on attachment 382590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382590&action=review Thank you! > Source/WebInspectorUI/UserInterface/Base/Main.js:925 > + return !WI._defaultFocusedQuickConcolePrompt && WI.quickConsole.prompt.focused; Nit: s/_defaultFocusedQuickConcolePrompt/_defaultFocusedQuickConsolePrompt/ > Source/WebInspectorUI/UserInterface/Base/Main.js:1364 > + WI._defaultFocusedQuickConcolePrompt = false; Ditto. > Source/WebInspectorUI/UserInterface/Base/Main.js:1546 > + WI._defaultFocusedQuickConcolePrompt = true; Ditto Comment on attachment 382590 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=382590&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Main.js:925 > + return !WI._defaultFocusedQuickConcolePrompt && WI.quickConsole.prompt.focused; Typo: console A better name could be: WI._didAutofocusConsolePrompt Created attachment 382619 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 382619 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 382619 [details]: imported/w3c/web-platform-tests/svg/text/visualtests/text-inline-size-003-visual.svg bug 203172 (author: sabouhallawa@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 382619 [details] Patch Rejecting attachment 382619 [details] from commit-queue. New failing tests: requestidlecallback/requestidlecallback-document-gc.html Full output: https://webkit-queues.webkit.org/results/13202266 Created attachment 382638 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-highsierra Platform: Mac OS X 10.13.6
Created attachment 382648 [details]
Patch
Comment on attachment 382648 [details] Patch Clearing flags on attachment: 382648 Committed r251958: <https://trac.webkit.org/changeset/251958> All reviewed patches have been landed. Closing bug. |