Summary: | webkitpy: Ignore case when comparing device types | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||||
Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, darin, ews-watchlist, glenn, lforschler, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=192161 https://bugs.webkit.org/show_bug.cgi?id=192162 https://bugs.webkit.org/show_bug.cgi?id=192472 |
||||||||||
Attachments: |
|
Description
Jonathan Bedard
2018-12-05 10:26:33 PST
Created attachment 356617 [details]
Patch
Comment on attachment 356617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=356617&action=review lgtm with typo fix. > Tools/ChangeLog:10 > + against DeviceTypes coming form the simulator runtime. typo: from Created attachment 356620 [details]
Patch for landing
The commit-queue encountered the following flaky tests while processing attachment 356620 [details]: http/wpt/mediarecorder/MediaRecorder-AV-video-only-dataavailable.html bug 192418 (author: youennf@gmail.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 356620 [details]: webgl/2.0.0/conformance/more/glsl/arrayOutOfBounds.html bug 192419 (author: justin_fan@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 356620 [details] Patch for landing Clearing flags on attachment: 356620 Committed r238906: <https://trac.webkit.org/changeset/238906> All reviewed patches have been landed. Closing bug. Comment on attachment 356620 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=356620&action=review > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:147 > + def test_comparsion_lower_case(self): Typo here: "comparsion" Reopening to attach new patch. Created attachment 356748 [details]
Patch for landing
(In reply to Darin Adler from comment #9) > Comment on attachment 356620 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=356620&action=review > > > Tools/Scripts/webkitpy/xcode/device_type_unittest.py:147 > > + def test_comparsion_lower_case(self): > > Typo here: "comparsion" Oops, thanks Darin, landing a fix for the typo. The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: inspector/canvas/recording-bitmaprenderer.html bug 192475 (author: drousso@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: imported/w3c/web-platform-tests/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-hangul.html bug 192476 (author: mjs@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: http/wpt/css/css-animations/start-animation-001.html bug 190903 (authors: dino@apple.com, fred.wang@free.fr, and graouts@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 356748 [details]: webgl/1.0.2/conformance/more/conformance/methods.html bug 192477 (author: roger_fong@apple.com) workers/bomb.html bug 192050 (author: fpizlo@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 356748 [details] Patch for landing Clearing flags on attachment: 356748 Committed r238943: <https://trac.webkit.org/changeset/238943> All reviewed patches have been landed. Closing bug. |