Bug 191572 – Enable process swap on cross-site navigation by default on macOS

• Component: WebKit2
• Status: RESOLVED FIXED

[Ryosuke Niwa]

Do that.

[Ryosuke Niwa]

Created attachment 354611 [details]
Enables the feature

[Chris Dumez]

Comment on attachment 354611 [details]
Enables the feature

r=me

[WebKit Commit Bot]

Comment on attachment 354611 [details]
Enables the feature

Clearing flags on attachment: 354611

Committed r238137: <https://trac.webkit.org/changeset/238137>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46033843>

[Ryan Haddad]

Enabling this introduced API test failures on macOS: 
https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20%28Tests%29/builds/9226/steps/run-api-tests/logs/stdio

[Chris Dumez]

The ProcessSwapOnNavigation API test failures are likely due to PSON getting forced to true now in cases where the tests are trying to test when PSON is disabled. Those are not too worrisome and can probably easily be fixed.

However, I am concerned about the other API test failures. We may want to roll out and investigate offline.

[Chris Dumez]

------------------------------
Test suite failed

Failed

    TestWebKitAPI.WebKit.ApplicationManifestBasic
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:98
        Value of: [manifest.name isEqualToString:@"A Web Application"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:99
        Value of: [manifest.shortName isEqualToString:@"WebApp"]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:100
        Value of: [manifest.applicationDescription isEqualToString:@"Hello."]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:101
        Value of: [manifest.startURL isEqual:[NSURL URLWithString:@"http://example.com/app/start"]]
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:102
        Value of: [manifest.scope isEqual:[NSURL URLWithString:@"http://example.com/app"]]
          Actual: false
        Expected: true
        

    TestWebKitAPI.WebKit.DecidePolicyForNavigationActionForPOSTFormSubmissionThatRedirectsToGET
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:517
        Expected equality of these values:
          WKNavigationTypeFormSubmitted
            Which is: 1
          [action navigationType]
            Which is: -1
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:522
        Expected equality of these values:
          "http"
          [[[action sourceFrame] securityOrigin] protocol]
            Which is: ""
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:523
        Expected equality of these values:
          "webkit.org"
          [[[action sourceFrame] securityOrigin] host]
            Which is: ""
        

    TestWebKitAPI.ProcessSwap.NavigationWithLockedHistoryWithoutPSON
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1493
        Expected equality of these values:
          webkitPID
            Which is: 65707
          applePID
            Which is: 65709
        

    TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:473
        Expected equality of these values:
          "PersistentCookieName=CookieValue; SessionCookieName=CookieValue"
          message.UTF8String
            Which is: "PersistentCookieName=CookieValue"
        

    TestWebKitAPI.ServiceWorkers.HasServiceWorkerRegistrationBit
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1144
        Expected equality of these values:
          1u
            Which is: 1
          webView.get().configuration.processPool._webProcessCount
            Which is: 2
        

    TestWebKitAPI.WebKit.DecidePolicyForNavigationActionForHyperlinkThatRedirects
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:470
        Expected equality of these values:
          WKNavigationTypeLinkActivated
            Which is: 0
          [action navigationType]
            Which is: -1
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:475
        Expected equality of these values:
          "http"
          [[[action sourceFrame] securityOrigin] protocol]
            Which is: ""
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:476
        Expected equality of these values:
          "webkit.org"
          [[[action sourceFrame] securityOrigin] host]
            Which is: ""
        

    TestWebKitAPI.ServiceWorkers.ServiceWorkerProcessCreation
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:1060
        Expected equality of these values:
          3u
            Which is: 3
          webView.get().configuration.processPool._webProcessCount
            Which is: 4
        

    TestWebKitAPI.WKProcessPool.InitialWarmedProcessUsed
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:74
        Value of: [pool _hasPrewarmedWebProcess]
          Actual: true
        Expected: false
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:75
        Expected equality of these values:
          1U
            Which is: 1
          [pool _webPageContentProcessCount]
            Which is: 2
        

    TestWebKitAPI.WebKit.DecidePolicyForNavigationActionForPOSTFormSubmissionThatRedirectsToPOST
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:564
        Expected equality of these values:
          WKNavigationTypeFormSubmitted
            Which is: 1
          [action navigationType]
            Which is: -1
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:569
        Expected equality of these values:
          "http"
          [[[action sourceFrame] securityOrigin] protocol]
            Which is: ""
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:570
        Expected equality of these values:
          "webkit.org"
          [[[action sourceFrame] securityOrigin] host]
            Which is: ""
        

    TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:262
        Value of: [WKWebsiteDataStore _defaultDataStoreExists]
          Actual: true
        Expected: false
        

    TestWebKitAPI.ProcessSwap.CrossSiteClientSideRedirectWithoutPSON
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        Received data during response processing, queuing it.
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1358
        Expected equality of these values:
          webkitPID
            Which is: 65640
          googlePID
            Which is: 65642
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1370
        Expected equality of these values:
          webkitPID
            Which is: 65640
          applePID
            Which is: 65643
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:1371
        Expected equality of these values:
          webkitPID
            Which is: 65640
          googlePID
            Which is: 65642
        

Crashed

    TestWebKitAPI.WebKit.GeolocationTransitionToLowAccuracy
        2018-11-13 11:29:39.907 com.apple.WebKit.WebContent.Development[63324:18897420] Application does not have the 'com.apple.security.network.client' entitlement.

Timeout

    TestWebKitAPI.IndexedDB.IndexedDBTempFileSize
        Attempted to create a NetworkLoad with a session (id=2) that does not exist.

    TestWebKitAPI.WebKit.GeolocationPermission
    TestWebKitAPI.WebKit.NotificationPermission
    TestWebKitAPI.WebKit.GeolocationTransitionToHighAccuracy

[Ryosuke Niwa]

Okay, let's rollout the change and investigate this offline.

[Ryan Haddad]

Reverted r238137 for reason:

Introduced API test failures on macOS.

Committed r238142: <https://trac.webkit.org/changeset/238142>

[Chris Dumez]

I am investigating the API test failures. Will fix them via dependency bugs.

[Chris Dumez]

Created attachment 354705 [details]
Patch

[Chris Dumez]

I believe all API tests will be passing on macOS once Bug 191638 and Bug 191640 are fixed.

[Chris Dumez]

Comment on attachment 354611 [details]
Enables the feature

All dependencies are in the commit queue. We can land this again once they have landed.

[Chris Dumez]

Oops, I think TestWebKitAPI.IndexedDB.IndexedDBTempFileSize may still be timing out.

[Ryosuke Niwa]

Created attachment 354896 [details]
Enables PSON by default on macOS

[Chris Dumez]

Comment on attachment 354896 [details]
Enables PSON by default on macOS

I preferred the other patch now that I separated from client and experimental states. The reason is that the other patch allowed the user to disable PSON via the experimental features. This new patch does not.

[Ryosuke Niwa]

(In reply to Chris Dumez from comment #17)
> Comment on attachment 354896 [details]
> Enables PSON by default on macOS
> 
> I preferred the other patch now that I separated from client and
> experimental states. The reason is that the other patch allowed the user to
> disable PSON via the experimental features. This new patch does not.

Okay, let's re-land the old patch then once the bug 191671 is fixed.

[Chris Dumez]

Comment on attachment 354611 [details]
Enables the feature

Let's do this!

[WebKit Commit Bot]

Comment on attachment 354611 [details]
Enables the feature

Clearing flags on attachment: 354611

Committed r238252: <https://trac.webkit.org/changeset/238252>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.