Bug 191618 - WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
Summary: WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 191572
  Show dependency treegraph
 
Reported: 2018-11-13 19:04 PST by Chris Dumez
Modified: 2018-11-13 19:50 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2018-11-13 19:06 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-11-13 19:04:51 PST
WKProcessPool.InitialWarmedProcessUsed API is failing with PSON enabled:
    TestWebKitAPI.WKProcessPool.InitialWarmedProcessUsed
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:74
        Value of: [pool _hasPrewarmedWebProcess]
          Actual: true
        Expected: false
        
        
        /Volumes/Data/slave/highsierra-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:75
        Expected equality of these values:
          1U
            Which is: 1
          [pool _webPageContentProcessCount]
            Which is: 2
Comment 1 Chris Dumez 2018-11-13 19:06:29 PST
Created attachment 354752 [details]
Patch
Comment 2 WebKit Commit Bot 2018-11-13 19:49:02 PST
Comment on attachment 354752 [details]
Patch

Clearing flags on attachment: 354752

Committed r238158: <https://trac.webkit.org/changeset/238158>
Comment 3 WebKit Commit Bot 2018-11-13 19:49:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-11-13 19:50:29 PST
<rdar://problem/46051431>