Bug 191671 - IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled
Summary: IndexedDB.IndexedDBTempFileSize API test times out with process prewarming en...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 191572
  Show dependency tree / graph
 
Reported: 2018-11-14 20:08 PST by Chris Dumez
Modified: 2019-02-27 11:28 PST (History)
7 users (show)

See Also:

Attachments
Patch (10.13 KB, patch)
2018-11-15 09:14 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-11-14 20:08:09 PST 
IndexedDB.IndexedDBTempFileSize API test times out with process prewarming enabled:
Timeout

    TestWebKitAPI.IndexedDB.IndexedDBTempFileSize
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        ERROR: SQLite database failed to checkpoint: database table is locked
        ./platform/sql/SQLiteDatabase.cpp(130) : bool WebCore::SQLiteDatabase::open(const WTF::String &, bool)
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        Attempted to create a NetworkLoad with a session (id=2) that does not exist.

Testing completed, Exit status: 3
Comment 1 Chris Dumez 2018-11-14 21:16:07 PST 
I know what's going on and have tests. Will upload a fix tomorrow.
Comment 2 Radar WebKit Bug Importer 2018-11-14 21:30:57 PST 
<rdar://problem/46086062>
Comment 3 Chris Dumez 2018-11-15 09:14:20 PST 
Created attachment 354944 [details]
Patch
Comment 4 WebKit Commit Bot 2018-11-15 14:01:38 PST 
Comment on attachment 354944 [details]
Patch

Clearing flags on attachment: 354944

Committed r238250: <https://trac.webkit.org/changeset/238250>
Comment 5 WebKit Commit Bot 2018-11-15 14:01:39 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2018-11-16 09:09:45 PST 
Comment on attachment 354944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354944&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:571
> +    // Make sure the network process knowns about all the sessions that have been registered before it started.

Typo: "knowns" instead of "knows".
Comment 7 Chris Dumez 2018-11-16 09:13:03 PST 
(In reply to Darin Adler from comment #6)
> Comment on attachment 354944 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=354944&action=review
> 
> > Source/WebKit/UIProcess/WebProcessPool.cpp:571
> > +    // Make sure the network process knowns about all the sessions that have been registered before it started.
> 
> Typo: "knowns" instead of "knows".

Fixed in <https://trac.webkit.org/changeset/238284>, thanks.